Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Install count #81

Merged
merged 8 commits into from
Jun 7, 2024
Merged

feat: Install count #81

merged 8 commits into from
Jun 7, 2024

Conversation

zebby09
Copy link
Contributor

@zebby09 zebby09 commented Jun 4, 2024

@zebby09 zebby09 linked an issue Jun 4, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jun 4, 2024

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 98.31% (🎯 85%) 175 / 178
🟢 Statements 98.34% (🎯 85%) 178 / 181
🟢 Functions 100% (🎯 85%) 52 / 52
🟢 Branches 86.9% (🎯 85%) 73 / 84
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/dataAccess/broker/hooks.ts 94.44% 100% 100% 94.44% 54, 139
src/mockData/addons.ts 100% 100% 100% 100%
src/pages/addonPage/addonPage.tsx 96.66% 76.19% 100% 96.55% 100
src/pages/addonPage/addonList/addonCard.tsx 100% 100% 100% 100%
src/types/addon.ts 100% 100% 100% 100%
Unchanged Files
src/components/addonTabs.tsx 100% 100% 100% 100%
src/components/header.tsx 100% 100% 100% 100%
src/components/installButton.tsx 100% 100% 100% 100%
src/components/loadingSpinner.tsx 100% 100% 100% 100%
src/components/searchBar.tsx 100% 100% 100% 100%
src/dataAccess/broker/setupBroker.tsx 100% 100% 100% 100%
src/dataAccess/store/api.ts 100% 100% 100% 100%
src/dataAccess/store/hooks.ts 100% 100% 100% 100%
src/dataAccess/store/searchSlice.ts 100% 100% 100% 100%
src/dataAccess/store/store.ts 100% 100% 100% 100%
src/mockData/authors.ts 100% 100% 100% 100%
src/mockData/users.ts 100% 100% 100% 100%
src/pages/addonPage/addonList/addonApi.ts 100% 100% 100% 100%
src/pages/addonPage/addonList/addonList.tsx 100% 93.75% 100% 100%
src/pages/homePage/homePage.tsx 100% 100% 100% 100%
Generated in workflow #223

Copy link
Contributor

@Tjalle-S Tjalle-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Install count is not correctly stored in dev mode.
  • There should be a test for this feature.
  • No addon count is displayed (only the icon) if the user is not logged in (but it should: unauthorised users should still be able to browse the marketplace.

@zebby09 zebby09 merged commit 08fe268 into main Jun 7, 2024
4 checks passed
@zebby09 zebby09 deleted the install-count branch June 7, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text overflow in the addon card is not correctly handled
2 participants