-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Rust based helpers #1
Conversation
many nits, 1spl rule
… and docs use fixes from links and fmt
Pr\[winning\] &= Pr\[b_B\leq b_A\] \\ | ||
&= Pr\[v_B/2 \leq b_A\] \\ | ||
&= Pr\[v_B \leq 2b_A\] \\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link checker see [thing]
as a markdown link - so we need to escape all []
| | Δx | Δy | Δy | Δz | Δz | max | | ||
| --- | --- | --- | --- | --- | --- | --- | | ||
| x | 1 | 2 | 2 | 2 | 2 | 2 | | ||
| y | 5 | 0 | 2 | 5 | 5 | 5 | | ||
| z | 10 | 10 | 10 | 0 | 5 | 10 | | ||
<!-- prettier-ignore --> | ||
| | Δx | Δy | Δy | Δz | Δz | max | | ||
| - | -- | -- | -- | -- | -- | --- | | ||
| x | 1 | 2 | 2 | 2 | 2 | 2 | | ||
| y | 5 | 0 | 2 | 5 | 5 | 5 | | ||
| z | 10 | 10 | 10 | 0 | 5 | 10 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prettier and dprint conflict on a few things, we want to run this on tables in almost all cases, but when these flop back and forth, use dprint and then ignore the item.
|
||
<!-- .element: class="fragment" data-fragment-index="1" --> | ||
|
||
- High level mechanisms of async backing | ||
|
||
<!-- .element: class="fragment" data-fragment-index="2" --> | ||
|
||
- The unincluded segment, and prospective parachains |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dprint want us to use a full space, that is OK for reveal, but not ergonomic to use. Better story on fragment
s use in this book should be done 🤔 - that is a reveal-md problem more than ours though.
<https://crates.io/crates/substrate-wasm-builder> (seen env variables, pretty useful!) <!-- markdown-link-check-disable-line --> | ||
<https://crates.io/crates/substrate-wasm-builder> (seen env variables, pretty useful!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot disable a check per line now, only a glop pattern for mlc config... for now
<diagram class="mermaid limit size-40"> | ||
<!-- prettier-ignore-start --> | ||
flowchart TD | ||
subgraph paraA[Parachain A .] | ||
executor --"success?"--> palletxcm | ||
palletxcm("pallet-xcm") --"execute"--> executor("xcm-executor") | ||
end | ||
execute("execute(xcm)") --> palletxcm | ||
<!-- prettier-ignore-end --> | ||
</diagram> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignore not required if there is no \n\n
present in the html element 👍
This workshop was an idea that came from first wave of PBA in Cambridge. The first time it was ever played was back in Buenos Aires. It's very much a PBA right of passage, so it's exciting to be able to play today. | ||
This workshop was an idea that came from first wave of PBA in Cambridge. | ||
The first time it was ever played was back in Buenos Aires. | ||
It's very much a PBA right of passage, so it's exciting to be able to play today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1SPL rule applied in many places here, seems to not break intended rendering 🤞
Introduces use of https://dprint.dev/ (formatting) and https://github.com/becheran/mlc/ (link checking).
Also runs these and many fixes are applied to have links passing with only warnings, and the fmt clean.
See the contributing guide page on use 😁