Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Port: Antonball Classic #1248

Merged
merged 32 commits into from
Jan 30, 2025

Conversation

RegularCharacter07
Copy link
Contributor

@RegularCharacter07 RegularCharacter07 commented Jan 27, 2025

New Port for Antonball Classic

Game Information

Submission Requirements

CFW Tests

Ensure your game has been tested on all major CFWs:

  • AmberELEC
  • ArkOS
  • ROCKNIX
  • muOS
  • Knulli

Resolution Tests

Test all major resolutions:

  • 480x320
  • 640x480
  • 720x720 (RGB30)
  • Higher resolutions (e.g., 1280x720)

File Structure

  • Your port should have the following structure:
    • portname/
      • port.json
      • README.md
      • screenshot.jpg
      • cover.jpg
      • gameinfo.xml
      • Port Name.sh
      • portname/

Additional Resources

For an in-depth guide on creating a pull request, refer to: PortMaster Game Packaging Guide

@cdeletre
Copy link
Collaborator

Hi @RegularCharacter07

You need to open a thread in the testing channel so that your port can be tested on all the CFW and screen resolutions.

You can keep this PR open as draft while everything gets ready.

@Cebion
Copy link
Collaborator

Cebion commented Jan 28, 2025

@RegularCharacter07
Copy link
Contributor Author

All tests have been done and everything works.

Copy link
Collaborator

@cdeletre cdeletre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry buddy, got a bunch of CR but overall it's looking good ;)

ports/antonballclassic/Antonball Classic.sh Outdated Show resolved Hide resolved
ports/antonballclassic/Antonball Classic.sh Outdated Show resolved Hide resolved
ports/antonballclassic/Antonball Classic.sh Outdated Show resolved Hide resolved
ports/antonballclassic/Antonball Classic.sh Outdated Show resolved Hide resolved
ports/antonballclassic/Antonball Classic.sh Show resolved Hide resolved
ports/antonballclassic/port.json Outdated Show resolved Hide resolved
ports/antonballclassic/port.json Outdated Show resolved Hide resolved
ports/antonballclassic/port.json Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot must be 640x480

Also, I would suggest to use PNG image format and optimize the image with an online tool such as https://compresspng.com/ or with pngquant to get a light file :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://portmaster.games/packaging.html#readme-md

Installation can be removed (it will be added on the website from the port.json automatically). But you're missing the Notes section where you must at least put a link to the game developper page (we also are used to thank them for making the game, and when RTR making it available for free in PM). Control section is missing as well.

RegularCharacter07 and others added 17 commits January 28, 2025 17:09
Copy link
Collaborator

@cdeletre cdeletre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last line to the final :D

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to cover.png :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to screenshot.png

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These libs won't be used (they are needed if you use oggenc/oggdec). you can remove the tools/libs folder.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the actual content of antonballclassic.port

Archive:  antonballclassic.port
  Length      Date    Time    Name
---------  ---------- -----   ----
        0  02-15-2024 21:14   lib/
        0  02-15-2024 21:14   lib/arm64-v8a/
  1055016  02-15-2024 20:35   lib/arm64-v8a/libc++_shared.so
  6226528  02-15-2024 20:35   lib/arm64-v8a/libyoyo.so
        0  02-15-2024 21:14   lib/armeabi-v7a/
   657200  02-15-2024 20:35   lib/armeabi-v7a/libc++_shared.so
  5511016  02-15-2024 20:35   lib/armeabi-v7a/libyoyo.so
        0  02-15-2024 21:14   lib/x86/
  1095476  02-15-2024 20:35   lib/x86/libc++_shared.so
  6231784  02-15-2024 20:35   lib/x86/libyoyo.so
        0  02-15-2024 21:14   lib/x86_64/
  1120816  02-15-2024 20:35   lib/x86_64/libc++_shared.so
  6432008  02-15-2024 20:35   lib/x86_64/libyoyo.so
---------                     -------
 28329844                     13 files

We only need lib/arm64-v8a/libyoyo.so the other files can be removed. Just run this command :

zip -d antonballclassic.port  "lib/arm64-v8a/libc++_shared.so" "lib/armeabi-v7a/*" "lib/x86_64/*" "lib/x86/*"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to update this file

See https://portmaster.games/packaging.html#readme-md

Installation can be removed (it will be added on the website from the port.json automatically). But you're missing the Notes section where you must at least put a link to the game developper page (we also are used to thank them for making the game, and when RTR making it available for free in PM). Control section is missing as well.

@Cebion
Copy link
Collaborator

Cebion commented Jan 29, 2025

Almost there :P

Copy link
Collaborator

@cdeletre cdeletre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close to the merge ;)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With gmloader/gmloadernext it's better to manipulate the port file with the unzip/zip command. Here you have made a RAR archive which doesn't work.

You can replace the file with this one. Just unzip the first level of archive to get the port file (which is as well a zip)

antonballclassic.port.zip

ports/antonballclassic/README.md Show resolved Hide resolved
Copy link
Collaborator

@cdeletre cdeletre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot one thing 🙃

],
"desc": "After a long night on the town, Anton's struggling to find his way back home. You'll have to help Anton out by using your balls to break the bricks!\n\nYou'll also run into pesky Ballbusters during your adventure together. Get rid of them by smacking them with your balls, or hitting them from behind!",
"desc_md": null,
"inst": "Download the game on itch.io https://summitsphere.itch.io/antonball and unzip all game data to antonballclassic/assets.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I forgot to CR for the missing assets folder, can you (re)create it and put a .gitkeep file into it ?

@kloptops kloptops merged commit 7986afe into PortsMaster:main Jan 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants