Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add CLICKHOUSE_PORT as option for externalClickhouse configs" #417

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Revert "Add CLICKHOUSE_PORT as option for externalClickhouse configs" #417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions charts/posthog/templates/_clickhouse.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@
{{- else -}}
- name: CLICKHOUSE_HOST
value: {{ required "externalClickhouse.host is required if not clickhouse.enabled" .Values.externalClickhouse.host | quote }}
- name: CLICKHOUSE_PORT
value: {{ .Values.externalClickhouse.port | quote }}
- name: CLICKHOUSE_CLUSTER
value: {{ required "externalClickhouse.cluster is required if not clickhouse.enabled" .Values.externalClickhouse.cluster | quote }}
- name: CLICKHOUSE_DATABASE
Expand Down
6 changes: 0 additions & 6 deletions charts/posthog/tests/__snapshot__/_clickhouse.tpl.yaml.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ should render with external clickhouse:
1: |
- name: CLICKHOUSE_HOST
value: foo.bar.net
- name: CLICKHOUSE_PORT
value: "9000"
- name: CLICKHOUSE_CLUSTER
value: somecluster
- name: CLICKHOUSE_DATABASE
Expand All @@ -52,8 +50,6 @@ should render with external clickhouse with more custom settings:
1: |
- name: CLICKHOUSE_HOST
value: foo.bar.net
- name: CLICKHOUSE_PORT
value: "9000"
- name: CLICKHOUSE_CLUSTER
value: customCluster
- name: CLICKHOUSE_DATABASE
Expand All @@ -70,8 +66,6 @@ should render with external clickhouse with secrets:
1: |
- name: CLICKHOUSE_HOST
value: foo.bar.net
- name: CLICKHOUSE_PORT
value: "9000"
- name: CLICKHOUSE_CLUSTER
value: somecluster
- name: CLICKHOUSE_DATABASE
Expand Down
2 changes: 0 additions & 2 deletions charts/posthog/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,8 +737,6 @@ clickhouse:
externalClickhouse:
# -- Host of the external cluster. This is required when clickhouse.enabled is false
host:
# -- Port of the external cluster.
port: 9000
# -- Name of the external cluster to run DDL queries on. This is required when clickhouse.enabled is false
cluster:
# -- Database name for the external cluster
Expand Down