Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update default persistence value in JS docs #9904

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

evanfreeze
Copy link
Contributor

@evanfreeze evanfreeze commented Nov 15, 2024

Changes

As of PostHog/posthog-js#927 and the subsequent release of 1.94.0 (changelog entry), localStorage+cookie is the default persistence value.

It looks like this got updated in the "Persistence" section, where it says "localStorage+cookie (default)" but didn't get updated in this "Config" section.

Checklist

  • Words are spelled using American English
  • Titles are in sentence case
  • Feature names are in sentence case too
  • Use relative URLs for internal links
  • If I moved a page, I added a redirect in vercel.json
  • Remove this template if you're not going to fill it out!

Useful resources

As of PostHog/posthog-js#927 and the subsequent release of 1.94.0 ([changelog entry](https://github.com/PostHog/posthog-js/blob/main/CHANGELOG.md#1940---2023-12-08)), `localStorage+cookie` is the default persistence value. 

It looks like this got updated in the "Persistence" section, where it says "localStorage+cookie (default)" but didn't get updated in this "Config" section.
Copy link

vercel bot commented Nov 15, 2024

@evanfreeze is attempting to deploy a commit to the PostHog Team on Vercel.

A member of the Team first needs to authorize it.

@evanfreeze evanfreeze changed the title Update default persistence value in JS docs [Docs] Update default persistence value in JS docs Nov 15, 2024
Copy link
Contributor

@ivanagas ivanagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog ✅ Ready (Inspect) Visit Preview Nov 15, 2024 5:22pm

@ivanagas ivanagas enabled auto-merge (squash) November 15, 2024 17:00
@ivanagas ivanagas merged commit a4dac73 into PostHog:master Nov 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants