Convert snmp params to uppercase. Added tests

PowerAruba · Nov 18, 2023 · c268f57 · c268f57
1 parent f71ad2b
commit c268f57
Show file tree

Hide file tree

Showing 2 changed files with 56 additions and 2 deletions.
diff --git a/PowerArubaCP/Public/NetworkDevice.ps1 b/PowerArubaCP/Public/NetworkDevice.ps1
@@ -140,7 +140,7 @@ function Add-ArubaCPNetworkDevice {
                 throw "If snmp_version is specified, community_string is mandatory."
             }
             $snmp_read = @{
-                snmp_version = $snmp_version
+                snmp_version = $snmp_version.ToUpper()
                 community_string = $community_string
                 zone_name = "default"
             }
@@ -385,7 +385,7 @@ function Set-ArubaCPNetworkDevice {
                 throw "If snmp_version is specified, community_string is mandatory."
             }
             $snmp_read = @{
-                snmp_version = $snmp_version
+                snmp_version = $snmp_version.ToUpper()
                 community_string = $community_string
                 zone_name = "default"
             }

diff --git a/Tests/integration/NetworkDevice.Tests.ps1 b/Tests/integration/NetworkDevice.Tests.ps1
@@ -403,6 +403,60 @@ Describe "Remove Network Device" {
 
 }
 
+Describe "Add Network Device" {
+
+    It "Add Network Device with snmp v2c" {
+        Add-ArubaCPNetworkDevice -name pester_SW6 -ip_address 192.0.2.6 -radius_secret MySecurePassword -vendor Cisco -snmp_version v2c -community_string myString
+        $nad = Get-ArubaCPNetworkDevice -name pester_SW6
+        $nad.name | Should -Be "pester_SW6"
+        $nad.ip_address | Should -Be "192.0.2.6"
+        $nad.vendor_name | Should -Be "Cisco"
+        $nad.snmp_read.snmp_version | Should -Be "v2c"
+        $nad.snmp_read.zone_name | Should -Be "default"
+        # community_string is always empty
+    }
+
+    It "Add Network Device with snmp v1" {
+        Add-ArubaCPNetworkDevice -name pester_SW6 -ip_address 192.0.2.6 -radius_secret MySecurePassword -vendor Cisco -snmp_version v1 -community_string myString
+        $nad = Get-ArubaCPNetworkDevice -name pester_SW6
+        $nad.name | Should -Be "pester_SW6"
+        $nad.ip_address | Should -Be "192.0.2.6"
+        $nad.vendor_name | Should -Be "Cisco"
+        $nad.snmp_read.snmp_version | Should -Be "v1"
+        $nad.snmp_read.zone_name | Should -Be "default"
+        # community_string is always empty
+    }
+
+    It "Add Network Device with snmp v2c then change it to v1" {
+        Add-ArubaCPNetworkDevice -name pester_SW6 -ip_address 192.0.2.6 -radius_secret MySecurePassword -vendor Cisco -snmp_version v2c -community_string myString
+        Get-ArubaCPNetworkDevice -name pester_SW6 | Set-ArubaCPNetworkDevice -snmp_version v1 -community_string myString
+        $nad = Get-ArubaCPNetworkDevice -name pester_SW6
+        $nad.name | Should -Be "pester_SW6"
+        $nad.ip_address | Should -Be "192.0.2.6"
+        $nad.vendor_name | Should -Be "Cisco"
+        $nad.snmp_read.snmp_version | Should -Be "v1"
+        $nad.snmp_read.zone_name | Should -Be "default"
+        # community_string is always empty
+    }
+
+    It "Add Network Device with snmp v1 then change it to v2c" {
+        Add-ArubaCPNetworkDevice -name pester_SW6 -ip_address 192.0.2.6 -radius_secret MySecurePassword -vendor Cisco -snmp_version v1 -community_string myString
+        Get-ArubaCPNetworkDevice -name pester_SW6 | Set-ArubaCPNetworkDevice -snmp_version v2c -community_string myString
+        $nad = Get-ArubaCPNetworkDevice -name pester_SW6
+        $nad.name | Should -Be "pester_SW6"
+        $nad.ip_address | Should -Be "192.0.2.6"
+        $nad.vendor_name | Should -Be "Cisco"
+        $nad.snmp_read.snmp_version | Should -Be "v2c"
+        $nad.snmp_read.zone_name | Should -Be "default"
+        # community_string is always empty
+    }
+
+    AfterEach {
+        Get-ArubaCPNetworkDevice -name pester_SW6 | Remove-ArubaCPNetworkDevice -confirm:$false
+    }
+
+}
+
 AfterAll {
     Disconnect-ArubaCP -confirm:$false
 }