Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tpls and macros - continuation #634

Merged
merged 56 commits into from
Nov 3, 2023
Merged

Fix tpls and macros - continuation #634

merged 56 commits into from
Nov 3, 2023

Conversation

cz4rs
Copy link
Collaborator

@cz4rs cz4rs commented Aug 29, 2023

This expands on the configuration rewrite done in #627.
Posting this from a separate branch to preserve original history.

@cz4rs cz4rs force-pushed the fix_tpls_and_macros__experimental branch 3 times, most recently from 3d0e69f to d6a7483 Compare August 29, 2023 12:49
cz4rs
cz4rs commented Aug 29, 2023
View reviewed changes
tests/CMakeLists.txt Outdated Show resolved Hide resolved
@cz4rs cz4rs force-pushed the fix_tpls_and_macros__experimental branch 5 times, most recently from bf4dcaf to fcc1ad4 Compare August 30, 2023 12:33
@cz4rs cz4rs force-pushed the fix_tpls_and_macros__experimental branch 2 times, most recently from c907377 to cfc74e2 Compare October 10, 2023 17:43
@cz4rs cz4rs force-pushed the fix_tpls_and_macros__experimental branch 7 times, most recently from 2b3bb08 to 2da75d7 Compare October 18, 2023 14:34
@cz4rs cz4rs force-pushed the fix_tpls_and_macros__experimental branch from d0c3e7d to 84658cc Compare October 31, 2023 19:39
@cz4rs cz4rs force-pushed the fix_tpls_and_macros__experimental branch 2 times, most recently from 9d30e47 to 43f9979 Compare October 31, 2023 20:21
@cz4rs cz4rs force-pushed the fix_tpls_and_macros__experimental branch from 0dc69c0 to 1b74bb6 Compare October 31, 2023 23:02
@cz4rs cz4rs marked this pull request as ready for review October 31, 2023 23:25
@cz4rs cz4rs requested a review from fnrizzi October 31, 2023 23:25
fnrizzi
fnrizzi reviewed Nov 2, 2023
View reviewed changes
include/pressio/macros.hpp Outdated Show resolved Hide resolved
fnrizzi
fnrizzi reviewed Nov 2, 2023
View reviewed changes
tests/cmake/options.cmake Outdated Show resolved Hide resolved
fnrizzi
fnrizzi reviewed Nov 2, 2023
View reviewed changes
tests/cmake/tpls.cmake Outdated Show resolved Hide resolved
@cz4rs cz4rs marked this pull request as draft November 2, 2023 16:44
@cz4rs cz4rs force-pushed the fix_tpls_and_macros__experimental branch from 7d303f7 to 8801fa0 Compare November 2, 2023 17:29
@cz4rs cz4rs marked this pull request as ready for review November 2, 2023 17:46
@cz4rs cz4rs requested a review from fnrizzi November 2, 2023 18:18
fnrizzi
fnrizzi approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@fnrizzi fnrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great thank you!

@fnrizzi fnrizzi merged commit bd19716 into develop Nov 3, 2023
14 checks passed
@fnrizzi fnrizzi mentioned this pull request Nov 7, 2023
Closed
@fnrizzi fnrizzi deleted the fix_tpls_and_macros__experimental branch November 11, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnrizzi fnrizzi fnrizzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
pressio
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cz4rs @fnrizzi