This repository has been archived by the owner on Feb 3, 2021. It is now read-only.
Correct negation of voucher discounts #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🆙 |
mcdado
changed the title
|
Anybody? |
Besides being more elegant and correct, this way enables developers to create custom behaviors with Cart Rules, where instead of offering discounts, they could increase the price. However, this change will not effect anybody else. See for example these screenshots: http://cl.ly/image/0e0g2D1u0Y45 (before) http://cl.ly/image/3b020a303N2v (after) You can see how now the normal case is still a normal minus, while with our custom built override we have a positive value, that is they way it's meant to be.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides being more elegant and correct, this way enables developers
to create custom behaviors with Cart Rules, where instead of offering
discounts, they could increase the price. However, this change will not
effect anybody else.
See for example these screenshots:
Before:
After:
You can see how now the normal case is still a normal minus, while with
our custom built override we have a positive value, that is they way
it's meant to be.
Never mind the rounding to four decimals, that is a customization.