Fix: ps_facetedsearch - In template creation, filters counter in BO is not correct #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fixed filters are 7 and not 6, and they are as follows: 1. Sub-categories filter 2. Product stock filter 3. Product extras filter 4. Product condition filter 5. Product brand filter 6. Product weight filter (slider) 7. Product price filter (slider)
|
Hello @Codencode! This is your first pull request on ps_facetedsearch repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
2 tasks
Hlavtox
approved these changes
Dec 19, 2024
|
Hello @Codencode, I tested your PR and it's good for me! 🎉 Number of filters selected and total filters are now the same and I don't found regression with the module on the FO or BO! Thanks!
|
paulnoelcholot
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixed filters are 7 and not 6, and they are as follows: