Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Can't access link blocks from BO with wrong language on employee #193

Closed
wants to merge 1 commit into from
Closed

Fix: Can't access link blocks from BO with wrong language on employee #193

wants to merge 1 commit into from

Conversation

Codencode
Copy link

Questions Answers
Description? When edititing the blocks in ps_linklist, it's not possible to access the blocks in multistore of the language of the employee is not matching the language of the shop.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#35275.

@Codencode
Copy link
Author

The problem occurs because in the situation described in the PR (PrestaShop/PrestaShop#35275) the system only saves the store's default language record.
By doing this, when retrieving the records, the gridsystem does not find the record relating to the employee's language and therefore does not show the blocks.

jolelievre
jolelievre approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Codencode

@jolelievre jolelievre modified the milestones: 6.0.5, 6.0.6 Feb 13, 2024
@florine2623 florine2623 self-assigned this Feb 26, 2024
@florine2623
Copy link
Contributor

A PR fixing the same issue has already been merged : #190

@MatShir can we close this one ?

@florine2623 florine2623 removed their assignment Feb 28, 2024
@florine2623 florine2623 added the Waiting for PM Status: Waiting for PM feedback label Feb 28, 2024
@jolelievre jolelievre removed this from the 6.0.6 milestone Feb 28, 2024
@kpodemski
Copy link
Contributor

Hello @Codencode

Could you see if the PR mentioned by @florine2623 will help you as well?

@Codencode
Copy link
Author

Hello @kpodemski,

yes the PR mentioned by @florine2623 solves the problem in a different way but it works.
I hadn't noticed otherwise I wouldn't have created this PR which I'm closing now.

@Codencode Codencode closed this Mar 5, 2024
@MatShir
Copy link

MatShir commented Mar 5, 2024

Thanks anyway @Codencode ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boherm boherm boherm approved these changes

@jolelievre jolelievre jolelievre approved these changes

Assignees
No one assigned
Labels
Waiting for PM Status: Waiting for PM feedback Waiting for QA
Projects
PR Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't access link blocks from BO with wrong language on employee
6 participants
@Codencode @florine2623 @kpodemski @MatShir @jolelievre @boherm