Add hookActionOrderSlipAdd #1206
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt75
force-pushed
the
feat/hookActionOrderSlipAdd
branch
2 times, most recently
from
e28c9e1 to
4310bfc
Compare
Matt75
force-pushed
the
feat/hookActionOrderSlipAdd
branch
from
4310bfc to
efb6ad3
Compare
Matt75
force-pushed
the
release/v8.3.6.0
branch
2 times, most recently
from
7e750da to
ae9af0c
Compare
L3RAZ
reviewed
Mar 4, 2024
config/common.yml
Outdated
| @@ -684,7 +686,7 @@ services: | |||
| arguments: | |||
| - "@ps_checkout.repository.pscheckoutcart" | |||
|
|
|||
| PrestaShop\Module\PrestashopCheckout\PayPal\Payment\Refund\CommandHandler\RefundPayPalCaptureCommandHandler: | |||
There was a problem hiding this comment.
Why change back the dependency name from full class name to ps_checkout.command.handler.paypal.payment.refund.refund_paypal_capture ?
Going forward we should create services/dependencies with full class name, as it's more convenient to call getService(Service::class) than having to remember what the service is named in config
There was a problem hiding this comment.
I had a problem with my dependencies, as it was the only one wrote with this syntax i thought that it may be the problem (it was obviously not the problem). Forgot to change it back.
As it's more convenient for the getService calls, I will add the new Query in this new style, as well as going back on this change
Matt75
force-pushed
the
release/v8.3.6.0
branch
3 times, most recently
from
7262153 to
8331d46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.