feat: add debounce #210
Merged
feat: add debounce #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
fox-john
added
🚧 WIP
fox-john
added
🥕 Radis to review
…/ps_eventbus into feat/add-debounce
…/ps_eventbus into feat/add-debounce
jokesterfr
reviewed
Dec 7, 2023
jokesterfr
reviewed
Dec 7, 2023
src/Api/LiveSyncApiClient.php
Outdated
| @@ -83,7 +83,7 @@ public function liveSync($shopContents, $shopContentId, $action) | |||
| 'User-Agent' => 'ps-eventbus/' . $this->module->version, | |||
| 'Content-Type' => 'application/json', | |||
| ], | |||
| '{"shopContents":' . json_encode($shopContents) . ', "shopContentId": ' . $shopContentId . ', "action": "' . $action . '"}' | |||
| '{"shopContents":' . json_encode($shopContent) . ', "shopContentId": ' . $shopContentId . ', "action": "' . $action . '"}' | |||
There was a problem hiding this comment.
To avoid calling json_encode, a faster way would be a direct variable interpolation:
php
'{"shopContents": ["' . $shopContent . '"], ..............
There was a problem hiding this comment.
I have this error when i try.
There was a problem hiding this comment.
That would mean shopContent is not of type string here?
jokesterfr
reviewed
Dec 7, 2023
jokesterfr
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.