Merge pull request #534 from fox-john/feat/change-sentry-capture-method

feat: replace segment by sentry for logs
PrestaShopCorp · Sep 30, 2021 · 7fb6150 · 7fb6150
2 parents 4bbc74d + e73a11a
commit 7fb6150
Show file tree

Hide file tree

Showing 7 changed files with 147 additions and 3 deletions.
diff --git a/_dev/package-lock.json b/_dev/package-lock.json
diff --git a/_dev/package.json b/_dev/package.json
@@ -18,6 +18,8 @@
     "@googleapis/content": "^1.2.0",
     "@googleapis/oauth2": "^0.2.0",
     "@prestashopcorp/segment-vue": "^1.2.9",
+    "@sentry/tracing": "^6.13.2",
+    "@sentry/vue": "^6.13.2",
     "@vue/composition-api": "^1.2.1",
     "bootstrap": "^4.5.3",
     "bootstrap-vue": "^2.21.1",

diff --git a/_dev/src/router/index.ts b/_dev/src/router/index.ts
@@ -1,5 +1,6 @@
 import Vue from 'vue';
 import VueRouter, {RouteConfig} from 'vue-router';
+import * as Sentry from '@sentry/vue';
 import Store from '../store';
 import CampaignPage from '../views/campaign-page.vue';
 import Configuration from '../views/configuration.vue';
@@ -103,4 +104,12 @@ const router = new VueRouter({
   },
 });
 
+Sentry.init({
+  Vue,
+  // @ts-ignore
+  dsn: global.psxMktgWithGoogleDsnSentry,
+  tracesSampleRate: 1.0,
+  logErrors: true,
+});
+
 export default router;
diff --git a/_dev/src/views/debug.vue b/_dev/src/views/debug.vue
@@ -266,7 +266,7 @@ export default {
     this.$store.dispatch('smartShoppingCampaigns/GET_REMARKETING_TRACKING_TAG_STATUS_MODULE');
     this.$store.dispatch('smartShoppingCampaigns/GET_REMARKETING_CONVERSION_ACTIONS_ASSOCIATED');
     this.$store.dispatch('app/REQUEST_DEBUG_DATA');
-    throw new Error('coucou les zamis !');
+    throw new Error('one error from mounted hook for testing');
   },
 };
 </script>
diff --git a/classes/Handler/ErrorHandler.php b/classes/Handler/ErrorHandler.php
@@ -45,7 +45,7 @@ public function __construct()
         $module = Module::getInstanceByName('psxmarketingwithgoogle');
 
         $this->client = new ModuleFilteredRavenClient(
-            Config::PSX_MKTG_WITH_GOOGLE_SENTRY_CREDENTIALS,
+            Config::PSX_MKTG_WITH_GOOGLE_SENTRY_CREDENTIALS_PHP,
             [
                 'level' => 'warning',
                 'tags' => [

diff --git a/classes/config/Config.php b/classes/config/Config.php
@@ -39,7 +39,8 @@ class Config
         'AdminPsgoogleshippingModule',
     ];
 
-    const PSX_MKTG_WITH_GOOGLE_SENTRY_CREDENTIALS = 'https://[email protected]/5949536';
+    const PSX_MKTG_WITH_GOOGLE_SENTRY_CREDENTIALS_PHP = 'https://[email protected]/5949536';
+    const PSX_MKTG_WITH_GOOGLE_SENTRY_CREDENTIALS_VUE = 'https://[email protected]/5984715';
     const PSX_MKTG_WITH_GOOGLE_SEGMENT_API_KEY = 'RqYiLJKyoWv13t9aKxBvza6vsCsRpPpC';
 
     const PSX_MKTG_WITH_GOOGLE_ACCOUNT_IS_LINKED = 'PSX_MKTG_WITH_GOOGLE_ACCOUNT_IS_LINKED';

diff --git a/controllers/admin/AdminPsxMktgWithGoogleModuleController.php b/controllers/admin/AdminPsxMktgWithGoogleModuleController.php
@@ -122,6 +122,7 @@ public function initContent()
             'psxMktgWithGoogleModuleVersion' => $this->module->version,
             'psxMktgWithGoogleOnProductionEnvironment' => $this->env->get('PSX_MKTG_WITH_GOOGLE_API_URL') === Config::PSX_MKTG_WITH_GOOGLE_API_URL,
             'psxMktgWithGoogleSegmentId' => $this->env->get('PSX_MKTG_WITH_GOOGLE_SEGMENT_API_KEY'),
+            'psxMktgWithGoogleDsnSentry' => $this->env->get('PSX_MKTG_WITH_GOOGLE_SENTRY_CREDENTIALS_VUE'),
             'psxMktgWithGoogleApiUrl' => $this->env->get('PSX_MKTG_WITH_GOOGLE_API_URL'),
             'psxMktgWithGoogleAdminUrl' => $this->context->link->getAdminLink('AdminPsxMktgWithGoogleModule'),
             'psxMktgWithGoogleAdminAjaxUrl' => $this->context->link->getAdminLink(