feat: Add spinner data-test, update boutton

PrestaShopCorp · Oct 30, 2023 · 91b0ef4 · 91b0ef4
1 parent 983b26b
commit 91b0ef4
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 2 deletions.
diff --git a/packages/components/button/src/button.vue b/packages/components/button/src/button.vue
@@ -10,7 +10,7 @@
       { 'puik-button--fluid': fluid },
     ]"
     :disabled="disabled"
-    :data-test="`button-${dataTest}`"
+    :data-test="`${dataTest}`"
     @click="setSelected"
   >
     <puik-icon

diff --git a/packages/components/button/stories/button.stories.ts b/packages/components/button/stories/button.stories.ts
@@ -74,7 +74,7 @@ export default {
     dataTest: {
       control: 'text',
       description:
-        'Set a data-test attribute to the button `button-${dataTest}` `left-icon-${dataTest}` `right-icon-${dataTest}`',
+        'Set a data-test attribute to the button `${dataTest}` `left-icon-${dataTest}` `right-icon-${dataTest}`',
     },
   },
   args: {

diff --git a/packages/components/spinner-loader/src/spinner-loader.ts b/packages/components/spinner-loader/src/spinner-loader.ts
@@ -33,6 +33,11 @@ export const spinnerLoaderProps = buildProps({
     required: false,
     default: 'bottom',
   },
+  dataTest: {
+    type: String,
+    required: false,
+    default: 'spinner-loader',
+  },
 } as const)
 
 export type SpinnerLoaderProps = ExtractPropTypes<typeof spinnerLoaderProps>

diff --git a/packages/components/spinner-loader/src/spinner-loader.vue b/packages/components/spinner-loader/src/spinner-loader.vue
@@ -8,6 +8,7 @@
     ]"
     aria-live="polite"
     role="status"
+    :data-test="dataTest"
   >
     <div
       class="puik-spinner-loader__spinner"

diff --git a/packages/components/spinner-loader/stories/spinner-loader.stories.ts b/packages/components/spinner-loader/stories/spinner-loader.stories.ts
@@ -62,6 +62,10 @@ export default {
         },
       },
     },
+    dataTest: {
+      control: 'text',
+      description: 'Set the data-test attribute on the spinner loader',
+    },
   },
   args: {
     size: 'md',