Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new component : Rating card #383

Merged
merged 11 commits into from
Nov 19, 2024
Merged

new component : Rating card #383

merged 11 commits into from
Nov 19, 2024

Conversation

mattgoud
Copy link
Collaborator

@mattgoud mattgoud commented Oct 9, 2024

❓ Types of changes

see #382

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • πŸ“¦ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

… Material Icons set to Material Symbols, add fill prop to icon component, remove useless size prop from rating-card component
@mattgoud mattgoud linked an issue Oct 9, 2024 that may be closed by this pull request
… totalRatings prop for web-component use case, update storie and add tests
@mattgoud mattgoud marked this pull request as ready for review October 10, 2024 13:34
node-type="span"
/>
</div>
<PuikIcon
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu peux passer le data test Γ  l'icon en props

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok done

guillaume60240
guillaume60240 previously approved these changes Nov 14, 2024
@mattgoud mattgoud self-assigned this Nov 19, 2024
@mattgoud mattgoud merged commit 27f99f0 into main Nov 19, 2024
3 of 5 checks passed
@mattgoud mattgoud deleted the 382-new-component-rating-card branch November 19, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⭐️[new-component]-Rating Card
2 participants