Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import for playground #393

Closed
wants to merge 1 commit into from
Closed

Conversation

kevin-carangeot
Copy link
Contributor

❓ Types of changes

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • πŸ“¦ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@kevin-carangeot kevin-carangeot self-assigned this Nov 29, 2024
Copy link
Collaborator

@mattgoud mattgoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should not directly modify the VueComponentsExample and WebComponentsExample files because they are part of the git repo for example.
You have to copy them and rename them by removing Example as indicated in the playground readme because the VueComponents and WebComponents files are not supposed to be pushed.

Maybe add a paragraph in comment in each of example files to explain the process ?

@kevin-carangeot
Copy link
Contributor Author

kevin-carangeot commented Dec 9, 2024

Ahh sorry, my bad.
Maybe this is more understandable like this:

VueComponentsView.example.vue
WebComponentsView.example.vue

But ok, good for me

@kevin-carangeot kevin-carangeot deleted the fix/import-playground branch December 9, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants