Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Select] - fix bug #412 - review disabled behavior #413

Conversation

mattgoud
Copy link
Collaborator

❓ Types of changes

see #412

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • πŸ“¦ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@mattgoud mattgoud added the bug Something isn't working label Jan 16, 2025
@mattgoud mattgoud self-assigned this Jan 16, 2025
@mattgoud mattgoud requested a review from krimz January 16, 2025 16:29
@mattgoud mattgoud merged commit 2af6878 into main Jan 17, 2025
5 checks passed
@mattgoud mattgoud deleted the 412-bug-select---ensure-all-select-behaviors-are-prevented-when-state-is-disabled branch January 17, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Select] - ensure all select behaviors are prevented when state is disabled
1 participant