Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backward compatibility of pull request 1722. #1725

Merged
merged 8 commits into from
Jan 22, 2025

Conversation

robinechuca
Copy link
Contributor

Same as 1722, keeping classical python set.

@WyattBlue
Copy link
Member

WyattBlue commented Jan 22, 2025

The underlying principle for to_ndarray() is that bytes(to_ndarray(frame)) should be the same as the ffmpeg cli when returning the pix_fmt with -c:v rawvideo.

While I haven't checked this, I'm 90% sure that means putting the channel first in yuv444p16. I would like for the channel to be first in all relevant pix_fmts if the former condition holds. I'm okay with a channel_last parameter, but quite what you're doing.

Also more little things:

  1. Don't put annotations in *.pyx, put then in the *.pyi files
  2. Learn how to use feature branches in git so I don't have to "Squash and Merge" for your PRs in the future
  3. Let's circle back to the skip_channel parm and the grb vs rgb thing when I'm happy with this PR, leave it out of this PR for now

@robinechuca
Copy link
Contributor Author

Ha ok, I understand the logic now! This should be written in the to_ndarray documentation.
2. You mean you would like I work an an other branch than "main"?

@WyattBlue WyattBlue merged commit 73baa3d into PyAV-Org:main Jan 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants