Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve htmlproofer failures in CI #70

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

jonafato
Copy link
Contributor

@jonafato jonafato commented Nov 2, 2024

Update URLs to use https instead of http

This is a bulk update to resolve almost all of the htmlproofer CI errors
(and generally to link to secure versions of websites). The remaining 7
errors reported by htmlproofer are conference-specific and relate to the
inability to validate links via libcurl, which may be due to servers not
supporting https or domains no longer resolving.


Update websites for a batch of conferences

These updates fall into two categories:

  1. Websites of inactive conferences that no longer exist or no longer
    contain conference-related content. In these instances, I've updated
    the links to the latest relevant snapshots I could find on the
    Internet Archive.

  2. Conferences whose canonical domains (as referenced by their websites
    or social media accounts) do not match the domains used here
    currently.

The last remaining htmlproofer error regards PyCon UK, whose canonical
domain is correctly listed here, but it does not respond to https
requests, and so I've reverted it back to http in this commit. This
ensures that the link is still usable but does not resolve the CI error
regarding http links.

@jefftriplett
Copy link
Contributor

I think linking to the https://2023.pyconuk.org website would be the most appropriate given all options.

@jonafato
Copy link
Contributor Author

jonafato commented Nov 2, 2024

I think linking to the https://2023.pyconuk.org website would be the most appropriate given all options.

@jonafato jonafato force-pushed the htmlproofer-fixes branch 2 times, most recently from 6bd5fce to 578a178 Compare November 2, 2024 03:30
@jefftriplett
Copy link
Contributor

@jonafato I was wrong. I don't have permission to re-run an action or to merge one. Otherwise, I'd merge this since it should pass in theory.

@glasnt
Copy link
Collaborator

glasnt commented Nov 2, 2024

The HTML Proofer section of the checks are now passing. There are separate issues with the Netlify checks that I am addressing in #72.

Because this is a major update to the data on the site, I'd prefer to wait until the Netlify fix is in, then rebase this PR to ensure that works before merging.

@glasnt
Copy link
Collaborator

glasnt commented Nov 2, 2024

For some reason, as a maintainer I cannot rebase this PR to get Netlify to run with the new configurations, and I cannot push a noop commit to make Netlify re-run this check. Manually retrying Netlify from that interface uses the older configurations.

@jonafato This PR needs to be manually rebased to force netlify to re-try with the new configurations from #72

@glasnt glasnt mentioned this pull request Nov 2, 2024
This is a bulk update to resolve almost all of the htmlproofer CI errors
(and generally to link to secure versions of websites). The remaining 7
errors reported by htmlproofer are conference-specific and relate to the
inability to validate links via libcurl, which may be due to servers not
supporting https or domains no longer resolving.
These updates fall into two categories:

1. Websites of inactive conferences that no longer exist or no longer
   contain conference-related content. In these instances, I've updated
   the links to the latest relevant snapshots I could find on the
   Internet Archive.

2. Conferences whose canonical domains (as referenced by their websites
   or social media accounts) do not match the domains used here
   currently.

The last remaining htmlproofer error regards PyCon UK, whose canonical
domain is correctly listed here, but it does not respond to https
requests, and so I've reverted it back to http in this commit. This
ensures that the link is still usable but does not resolve the CI error
regarding http links.
@jonafato jonafato force-pushed the htmlproofer-fixes branch 2 times, most recently from 9265424 to d6fe819 Compare November 2, 2024 23:20
@glasnt
Copy link
Collaborator

glasnt commented Nov 2, 2024

Netlify is working 🥳

Just 3 htmlproof errors left

@jonafato
Copy link
Contributor Author

jonafato commented Nov 2, 2024

These errors are not present on my local build and were just timeouts. I've pushed once more to re-trigger the build, which as now passed. If this job continues to be flaky, I'll look into configuring the timeout on these checks. In particular, these seemed to be failing on archive.org links, and it wouldn't surprise me to see an infrequently accessed archive of a conference website respond slowly.

@glasnt
Copy link
Collaborator

glasnt commented Nov 2, 2024

All checks currently green, so will merge ✅

@glasnt glasnt merged commit 67e1ba7 into PyCon:gh-pages Nov 2, 2024
5 checks passed
@jonafato jonafato deleted the htmlproofer-fixes branch November 2, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants