Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make copydir work again - fixes issue #90 #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [1.1.2] - 2024-01-09

### Fixed

- fs.copydir is now working again with the latest version of FS - see [issue #90](https://github.com/PyFilesystem/s3fs/issues/90)

## [1.1.1] - 2019-08-14

### Changed
Expand Down
4 changes: 3 additions & 1 deletion fs_s3fs/_s3fs.py
Original file line number Diff line number Diff line change
Expand Up @@ -775,7 +775,9 @@ def upload(self, path, file, chunk_size=None, **options):
file, self._bucket_name, _key, ExtraArgs=self._get_upload_args(_key)
)

def copy(self, src_path, dst_path, overwrite=False):
def copy(self, src_path, dst_path, overwrite=False, preserve_time=False):
if preserve_time:
raise NotImplementedError("preserve_time is not yet supported with S3 backend")
if not overwrite and self.exists(dst_path):
raise errors.DestinationExists(dst_path)
_src_path = self.validatepath(src_path)
Expand Down
2 changes: 1 addition & 1 deletion fs_s3fs/_version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "1.1.1"
__version__ = "1.1.2"