-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refac test implementation #146
base: dev
Are you sure you want to change the base?
Conversation
@AntonReinhard This one is almost done. I have a fix for the GPU tests, which I tested for CUDA, and I will push if I tested it locally for AMDGPU as well. I think most of the rest could be reviewed. Sorry for the long list of changes, but most of it is reshuffling and renaming of things. Btw: I expect no comment earlier than mid January 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, removing the circular dependency will definitely help the future development.
I've looked through more or less on surface-level since it's kind of a lot 😅
Co-authored-by: Anton Reinhard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the rapid reply. I changed the code accordingly.
With this PR, I propose a major refactoring of the test implementation, mostly to drop
QEDcore.jl
as a test dependency. See #144 for details.TODO (unit tests itself)
propagator
base_state
TODO
)QEDcore.jl
TODO (test implementation)
TestPhaseSpacePoint(...,moms)
type-stableTODO (general)
(TestMomentum{T}, TestMomentumMutable{T})
whereT<:Union{Float16,Float32, Float64}
(not just forTestMomentum{Float64}
)Final remarks
Solves #144.
Makes #140 easier to achive.