Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gaussian Pulsed Plane Wave field #27

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

steindev
Copy link
Member

@steindev steindev commented Jun 11, 2024

Add Gaussian pulsed plane wave field. In principle this is a copy-paste-replace implementation of the CosSquarePulse.

An implementation of the generic_spectrum computation using pre-calculated formulas would be good, but can be added later.

@steindev steindev added 06 - Feature-request Missing a feature or functionality 07 - Documentation Improvements or additions to documentation 08 - Testing Related to unit or integration tests labels Jun 11, 2024
@steindev steindev requested a review from szabo137 June 11, 2024 19:13
@szabo137
Copy link
Member

szabo137 commented Jun 11, 2024

Please format your code correctly by hitting

# install dependencies
julia --project=.formatting -e 'import Pkg; Pkg.instantiate()'
# format all documents
julia --project=.formatting .formatting/format_all.jl

in your local clone of the repo 😺

Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this. I have just some small comments.

Regarding the analytical formulas of the generic spectrum, could you please open a respective issue and remind us to add it later?

src/pulses/gaussian.jl Outdated Show resolved Hide resolved
src/pulses/gaussian.jl Outdated Show resolved Hide resolved
@szabo137
Copy link
Member

Since #26 is merged, please rebase to dev and force push.

@steindev steindev force-pushed the topic-2024-05_gaussian-ppw branch 2 times, most recently from 100a758 to f6fc9e3 Compare June 18, 2024 11:35
@szabo137
Copy link
Member

We are currently in the middle of a refactoring of QED.jl (see QEDjl-project/QuantumElectrodynamics.jl#35 for details). Therefore we prioritized #29 over this one. If you want to proceed, I suggest merging the current dev into your branch and fixing the merge conflicts. Then force-pushing again. Please be aware of the QEDbase namespace barrier introduced in #29 (see the issue on restructuring above for clarification or just ask here)

@szabo137
Copy link
Member

@steindev The refactoring is finished successfully. Please rebase and force push to proceed with this one.

@steindev steindev force-pushed the topic-2024-05_gaussian-ppw branch from f6fc9e3 to e9504e7 Compare October 29, 2024 12:36
@steindev
Copy link
Member Author

@szabo137 PR is rebased and ready for review/merge.

Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Looks good for me.

@steindev steindev merged commit e4efd9c into QEDjl-project:dev Oct 29, 2024
4 checks passed
@steindev steindev deleted the topic-2024-05_gaussian-ppw branch October 29, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
06 - Feature-request Missing a feature or functionality 07 - Documentation Improvements or additions to documentation 08 - Testing Related to unit or integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants