-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gaussian Pulsed Plane Wave field #27
Add Gaussian Pulsed Plane Wave field #27
Conversation
Please format your code correctly by hitting # install dependencies
julia --project=.formatting -e 'import Pkg; Pkg.instantiate()'
# format all documents
julia --project=.formatting .formatting/format_all.jl in your local clone of the repo 😺 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this. I have just some small comments.
Regarding the analytical formulas of the generic spectrum, could you please open a respective issue and remind us to add it later?
Since #26 is merged, please rebase to |
100a758
to
f6fc9e3
Compare
We are currently in the middle of a refactoring of |
@steindev The refactoring is finished successfully. Please rebase and force push to proceed with this one. |
f6fc9e3
to
e9504e7
Compare
@szabo137 PR is rebased and ready for review/merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Looks good for me.
Add Gaussian pulsed plane wave field. In principle this is a copy-paste-replace implementation of the
CosSquarePulse
.An implementation of the
generic_spectrum
computation using pre-calculated formulas would be good, but can be added later.