Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Call correct event so doors now can be toggled #46

Merged
merged 9 commits into from
Feb 25, 2024

Conversation

rasm945i
Copy link
Contributor

Description

Currently an invalid event is called when toggling the doors. I call the correct event.

Checklist

  • [ X ] I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • [ X ] My pull request fits the contribution guidelines & code conventions.

@solareon
Copy link
Contributor

I see the fixes for the radial menu but what are all these additional changes with moving out the vehicle menu into a separate file?

@rasm945i
Copy link
Contributor Author

This is very awkward. I think I accidentally pushed the wrong thing. I made personal changes (removed things and adjusted when menus are shown) which is what you mention.
It was only supposed to be changes to the config, I'm unsure how I messed up so bad, I apologize.

@rasm945i
Copy link
Contributor Author

It's only the first commit, the one starting with "fix: " that's supposed to be pulled. I have no clue why the rest got smushed into this pullrequest

@BerkieBb
Copy link
Contributor

Revert everything besides the changes in the config, they are not necessary. The cl_vehicle stuff should be in a separate PR

@rasm945i
Copy link
Contributor Author

I hope I did it right.
TIL that the first thing I do after forking something, is to create a branch for my personal adjustments to avoid this kind of mess.

@BerkieBb BerkieBb merged commit 5400313 into Qbox-project:main Feb 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants