Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add letter spacing to Text elements #14

Merged
merged 10 commits into from
Dec 28, 2023
Merged

feat: add letter spacing to Text elements #14

merged 10 commits into from
Dec 28, 2023

Conversation

vshakitskiy
Copy link
Contributor

fixed #3

@vercel Vercel
Copy link

vercel bot commented Dec 27, 2023

@vshakitskiy is attempting to deploy a commit to the Tom Team on Vercel.

A member of the Team first needs to authorize it.

QuiiBz
QuiiBz requested changes Dec 28, 2023
View reviewed changes
Copy link
Owner

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! One small comment:

apps/dashboard/src/components/RightPanel/FontSection.tsx Outdated Show resolved Hide resolved
@vshakitskiy
Copy link
Contributor Author

Now works fine.

@vshakitskiy vshakitskiy requested a review from QuiiBz December 28, 2023 11:30
@vercel Vercel
Copy link

vercel bot commented Dec 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ogstudio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 28, 2023 0:13am

@QuiiBz QuiiBz changed the title fix: letter spacing feat: add letter spacing to Text elements Dec 28, 2023
QuiiBz
QuiiBz approved these changes Dec 28, 2023
View reviewed changes
Copy link
Owner

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just fixed the typecheck error that occurred because of the rebase.

@QuiiBz QuiiBz enabled auto-merge (squash) December 28, 2023 12:13
@QuiiBz QuiiBz merged commit 03a12bb into QuiiBz:main Dec 28, 2023
5 checks passed
@vshakitskiy vshakitskiy deleted the fix/letterSpacing branch December 28, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuiiBz QuiiBz QuiiBz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support letterSpacing in text
2 participants
@vshakitskiy @QuiiBz