Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ModEntrypoint as an API for AdapterLoadableClassEntry #380

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

AlexIIL
Copy link
Contributor

@AlexIIL AlexIIL commented Oct 23, 2023

Since the only public changes are generics, existing mods which use getEntrypoints() (which they shouldn't as it's all either PLUGIN_API or LEGACY_EXPOSED) will continue to work in binary (compiled) form, but not source form.

ModEntrypoint intentionally doesn't expose the adapter or value at the moment since only loader itself should need it, at least in theory.

This also removes the plugins field from the QMJ reader, since it used to use AdapterLoadableClassEntry but isn't actually hooked up anywhere (as actual plugins don't get defined in this way)

This also has two extra API changes:

  • Adds ModLicense.fromIdentifier & fromIdentifierOrDefault, which exposes the same methods in ModLicenseImpl
  • Adds QuiltPluginManager.loadZipNow, which is an immediate version of loadZip

@AlexIIL
Copy link
Contributor Author

AlexIIL commented Oct 23, 2023

This will go in 0.22, since it's a bit more breaking than other changes.

@AlexIIL AlexIIL merged commit 80f6abe into QuiltMC:develop Nov 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant