Skip to content

Commit

Permalink
Update CI from deprecated pages action to Wrangler action (#260)
Browse files Browse the repository at this point in the history
* Switch to modern wrangler action for deployments.

The pages action we use is deprecated.

* IDEs that spellchecks comments reveals things.
  • Loading branch information
Southpaw1496 authored Nov 29, 2024
1 parent d64dd4a commit fd8b3a5
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions .github/workflows/publish-website.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,14 @@ jobs:
path: functions
run-id: ${{ env.GITHUB_RUN_ID }}
github-token: ${{ env.GITHUB_TOKEN }}
# The following hack is required because Cloudflare can't compile the workeers in the functions/ directory seperately from deploying, so it needs the packages they use in order to compile them at deployment time, but installing *everything* in package.json would be a waste. The build and publish steps can't go in the same job, because PR Previews have to build the site without publishing it (since they can't access secrets). Hopefully we can remove the need for this in the future by switching to Astro Actions, which should be compiled with the rest of the site.

# The following hack is required because Cloudflare can't compile the workers in the functions/ directory separately from deploying, so it needs the packages they use in order to compile them at deployment time, but installing *everything* in package.json would be a waste. The build and publish steps can't go in the same job, because PR Previews have to build the site without publishing it (since they can't access secrets). Hopefully we can remove the need for this in the future by switching to Astro Actions, which should be compiled with the rest of the site.
- name: Install packages required by functions
run: npm install xml-js semver-sort string_decoder buffer
- name: Publish to Cloudflare Pages
id: cloudflare-publish # This step needs an ID because its outputs may be needed in subsequent jobs.
uses: cloudflare/pages-action@v1
uses: cloudflare/wrangler-action@v3
with:
apiToken: ${{ env.CLOUDFLARE_API_TOKEN }}
accountId: ${{ env.CLOUDFLARE_ACCOUNT_ID }}
projectName: quiltmc-org
directory: dist
branch: ${{ inputs.branch }}
command: pages deploy dist --project-name quiltmc-org --branch ${{ inputs.branch }}

2 comments on commit fd8b3a5

@Cozy-GitHub
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See preview on Cloudflare Pages:

@Cozy-GitHub
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See preview on Cloudflare Pages:

Please sign in to comment.