Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add row limit setting of data viewer and support Apache Arrow Table #945

Merged
merged 6 commits into from
Feb 3, 2022

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Jan 17, 2022

What problem did you solve?

close #944

Currently, when displaying a data frame in the data viewer, temporary files are written out and read in, which does not work well for huge data frames with more than a few million rows. (related to #619, #837)
I would like to add an option to limit the number of records loaded into the data viewer, as it is often enough to see some of the content without loading all the records into the data viewer.
I would also like to add support for the Apache Arrow Table, which is becoming a strong choice for data frame compatibility when dealing with large numbers of records.
By controlling the number of records to be displayed, a huge Arrow Table can be displayed in the data viewer without stress.

(If you have)Screenshot

image

image

image

image

@eitsupi eitsupi marked this pull request as ready for review January 18, 2022 12:13
@eitsupi eitsupi changed the title Add row limit setting of data viewer and support Arrow Table Add row limit setting of data viewer and support Apache Arrow Table Jan 18, 2022
@eitsupi
Copy link
Contributor Author

eitsupi commented Jan 19, 2022

When I tried the data viewer with a huge data frame, I got the impression that limiting it to 100,000 records only waited a few seconds, but with 1 million records it wasn't clear if it was working.
It may be better to limit the default to around 100,000 records instead of unlimited.

R/session/vsc.R Outdated Show resolved Hide resolved
R/session/vsc.R Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@eitsupi
Copy link
Contributor Author

eitsupi commented Feb 2, 2022

Thank you for your review. I edited them.

It seems to have failed to check, but it may be a problem in GitHub Actions.

Copy link
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@renkun-ken renkun-ken merged commit 25b3dda into REditorSupport:master Feb 3, 2022
@eitsupi eitsupi deleted the dataview-limit branch February 3, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View Apache Arrow Table
2 participants