Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation revision #194

Merged
merged 21 commits into from
Dec 25, 2023
Merged

Validation revision #194

merged 21 commits into from
Dec 25, 2023

Conversation

dr-orlovsky
Copy link
Member

@dr-orlovsky dr-orlovsky commented Dec 15, 2023 •
edited
Loading

This is a carefull revisioning of all the validation workflow, which resulted in:

  • simplified validation code
  • more documentation on the validation
  • removal of unnecessary error types
  • addition of new validation criteria (like state transition consistency and non-cyclic history)
  • faster validation performance
  • support for both tapret and opret commitments in the same witness transaction
  • better support for multiple layer1's
  • much simplified consignment APIs
  • removal of trust assumptions for the consignment provider (like RGB standard library)
  • support for consignment implementations which will not store the whole consignment in memory

Depends on BP-WG/bp-core#69 and #195

@dr-orlovsky dr-orlovsky added refactoring Code refactoring *consensus* Issues affecting distributed concensus *security* Issues affecting safety/security (include undefined behaviours) labels Dec 15, 2023
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Dec 15, 2023
@dr-orlovsky dr-orlovsky force-pushed the v0.11 branch 2 times, most recently from 19d4611 to 1612b68 Compare December 17, 2023 09:45
cryptoquick
cryptoquick approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

These are big improvements and I see no obvious issues

@dr-orlovsky dr-orlovsky merged commit ea12425 into v0.11 Dec 25, 2023
@dr-orlovsky dr-orlovsky deleted the validation branch April 18, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptoquick cryptoquick cryptoquick approved these changes

@theacdutra theacdutra theacdutra approved these changes

@nicbus nicbus Awaiting requested review from nicbus

@zoedberg zoedberg Awaiting requested review from zoedberg

Assignees
No one assigned
Labels
*consensus* Issues affecting distributed concensus refactoring Code refactoring *security* Issues affecting safety/security (include undefined behaviours)
Projects
No open projects
Specification & reference implementation
Status: Done
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dr-orlovsky @cryptoquick @theacdutra