Skip to content

Commit

Permalink
print more explicit message when 'all samples' group is causing tree …
Browse files Browse the repository at this point in the history
…discrepancy. #119
  • Loading branch information
mikejiang committed Nov 10, 2020
1 parent 8ef0630 commit 465ad19
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion R/flowJoWorkspace_Methods.R
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,19 @@ backend <- match.arg(backend, c("h5", "tile"))
# # try to post process the GatingSet to split the GatingSets(based on different the gating trees) if needed
gslist <- suppressMessages(gs_split_by_tree(gs))
if(length(gslist) > 1)
warning("GatingSet contains different gating tree structures and must be cleaned before using it! ")
{
msg <- "GatingSet contains different gating tree structures and must be cleaned before using it!\n "

This comment has been minimized.

Copy link
@gfinak

gfinak Nov 11, 2020

Member

Does cytoqc do this yet? Can we recommend users pass their imported data through cytoqc?

This comment has been minimized.

Copy link
@mikejiang

mikejiang Nov 11, 2020

Member

Yes, cqc_check_gate does that. I will point to that in the message.

if(grepl("all samples", groups[groupInd], ignore.case = TRUE))
{
msg <- c(msg
, "It seems that you selected the 'All Samples' group,"
," which is a generic group and typically contains samples with different gating schemes attached."
, "Please choose a different sample group and try again.")
}
warning(msg)

}

gs
}

Expand Down

0 comments on commit 465ad19

Please sign in to comment.