feat: implemented cloud agent #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Villegas <[email protected]>
Signed-off-by: Alejandro Villegas <[email protected]>
Closed
11 tasks
Signed-off-by: Alejandro Villegas <[email protected]>
…tServer and clients objects for better coding Signed-off-by: Alejandro Villegas <[email protected]>
Signed-off-by: Alejandro Villegas <[email protected]>
Signed-off-by: Alejandro Villegas <[email protected]>
Signed-off-by: Alejandro Villegas <[email protected]>
…TP responses causing errors on the Console Signed-off-by: Alejandro Villegas <[email protected]>
Signed-off-by: Alejandro Villegas <[email protected]>
Signed-off-by: Alejandro Villegas <[email protected]>
Signed-off-by: Alejandro Villegas <[email protected]>
Signed-off-by: Alejandro Villegas <[email protected]>
Signed-off-by: Alejandro Villegas <[email protected]>
…ests for better performance Signed-off-by: Alejandro Villegas <[email protected]>
…r check; Vars renaming to prevent name collision; fixed comments typos Signed-off-by: Alejandro Villegas <[email protected]>
Signed-off-by: Alejandro Villegas <[email protected]>
Signed-off-by: Alejandro Villegas <[email protected]>
Signed-off-by: Alejandro Villegas <[email protected]>
Merged
vbelouso
reviewed
Jan 29, 2025
Signed-off-by: Alejandro Villegas <[email protected]>
vbelouso
reviewed
Jan 30, 2025
| } | ||
|
|
||
| // PowerOff | ||
| logger.Warn("Powering On Cluster", |
There was a problem hiding this comment.
Typo, must be Powering Off Cluster
vbelouso
reviewed
Jan 30, 2025
|
|
||
| // PowerOn | ||
| logger.Warn("Powering On Cluster", | ||
| zap.String("accound_id", req.AccountName), |
There was a problem hiding this comment.
Typo for the entire file. Must be account_name
vbelouso
reviewed
Jan 30, 2025
|
|
||
| // Serving gRPC | ||
| if err := grpcServer.Serve(lis); err != nil { | ||
| log.Fatalf("Error al servir: %v", err) |
vbelouso
reviewed
Jan 30, 2025
| grpcServer := grpc.NewServer(grpc.UnaryInterceptor(LoggingInterceptor)) | ||
| reflection.Register(grpcServer) | ||
| if grpcServer == nil { | ||
| fmt.Println("la jodimos") |
vbelouso
reviewed
Jan 30, 2025
| } | ||
|
|
||
| // PowerOn | ||
| logger.Warn("Powering On Cluster", |
There was a problem hiding this comment.
Mixing the logger for the entire file
If we are using a service logger it should be a.logger.warn instead of logger.warn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #98