Fixing RDS UI changes and the application to instance binding #83

ikanias · 2023-03-12T17:41:12Z

Fixed the changes Dev added to RDS UI and verified that the test of binding an application to a DBSC works properly.

mrrajan · 2023-03-13T05:56:06Z

resources/keywords/deploy_application.resource

@@ -30,7 +30,7 @@ User Creates Service Binding Between ${databaseProvider} DBSC Instance And Impor
    ${bindName}=    Update Service Binding    ${newProject}    ${instanceUUID}    ${appname}
    Set Test Variable    ${bindName}
    Create Service Binding      ${newProject}
-    Wait Until Keyword Succeeds    3x    1s     Wait Until Page Contains Element    ${elemSrvcBindArrow}
+    Wait Until Keyword Succeeds    10x    1s     Wait Until Page Contains Element    ${elemSrvcBindArrow}


@ikanias Do we need 10s wait time?

@mrrajan if we use less then that most of the times the test will fail. Happend to me a lot when I ran the tests.

mrrajan

@ikanias I have added review comments and Please attach the test results

mrrajan · 2023-03-13T06:01:21Z

resources/keywords/import_provider_account.resource

-    ${btnMenuOptDropDownUpd}=    Replace String    ${btnMenuOptDropDown}    <<menuopt>>    ${option}
-    Element Should Be Visible    ${btnMenuOptDropDownUpd}
-    Click Element    ${btnMenuOptDropDownUpd}
+    Wait Until Keyword Succeeds    10s    1s    Wait Until Element Is Visible    ${btnMenuDropDown}


@ikanias Do we need this change? The earlier one was dynamic and capable of selecting dropdown values from given menu option like
"Select Import Database Provider Account From Configure Button DropDown"
"Select Create Database Instance From Configure Button DropDown"

The previous one is not working anymore and the tests are failing over it, because the 'menu' we were looking for does not exist anymore in the DOM

@ikanias Can you please review again, As the keyword "Select ${option} From ${menu} Button DropDown" updated dynamically and it worked as expected. Attached the screenshot

Strange... Sure will try again

By the way it worked for me too before even when I removed these lines:
${btnMenuOptDropDownUpd}= Replace String ${btnMenuOptDropDown} <> ${option}
Element Should Be Visible ${btnMenuOptDropDownUpd}
Click Element ${btnMenuOptDropDownUpd}
So probably these commands(the ones I removed) are either redundant or not used.
The function 'Select {option} from {menu} Button DropDown' worked for me as well

mrrajan · 2023-03-13T06:02:23Z

resources/keywords/import_provider_account.resource

+    Element Should Be Visible    ${btnMenuOptDropDown}
+    Click Element    ${btnMenuOptDropDown}
+
+Select ${option} From ${menu} Button DropDown Provision


@ikanias As mentioned on the above, this is been already handled with existing keyword

As mentioned in my previous reply, the 'menu' parameter is not working properly anymore and is not displayed in the DOM anymore

Same as above

mrrajan · 2023-03-13T06:05:38Z

resources/keywords/import_provider_account.resource

@@ -284,6 +288,14 @@ User Imports ${isv} Provider Account Using CLI
 Provider Account Imported Successfully Using CLI
    Wait Until Keyword Succeeds    4x    5s    Describe Provider Account Using OC CLI

+User Navigates To Add ${databaseProvider} Topology Screen From Developer View


@ikanias Duplicate - Keyword "User Navigates To Add Topology Screen From Developer View" available under import_provider_account.resource file, where the database provider can be send as a parameter like "User Navigates To Add Topology Screen From Developer View MongoDB"

OK got it. I see that the other function is:
User Navigates To Add Topology Screen From Developer View
[Arguments] ${databaseProvider} ${ns}=${operatorNamespace} ${developer}=False
User Selects Developer View
User Filters ${ns} Namespace On Project Dropdown
User Navigates To Developers Catalog Add Screen
IF "${developer}"=="False"
User Clicks On Cloud Hosted Database Menu
User Selects ${databaseProvider} Tile Under Cloud Hosted Database
Click Element ${btnDBProvAddTopology}
END

Is this the one we should keep?

OK got you. fixed it to be as you described.

mrrajan · 2023-03-13T06:09:54Z

resources/keywords/import_provider_account.resource

@@ -322,8 +334,10 @@ Import Provider Account Failure For DBaaS Policy
    Wait Until Page Contains Element    ${errCreateDBaaSPolicy}     timeout=20s

 User Navigates To Import ${databaseProvider} Provider Account On Developer View
-    User Navigates To Add Topology Screen From Developer View      ${databaseProvider}      ${DBaaSTestNS}
-    User Navigates To Import Provider Account Screen From Developer View
+    Wait Until Page Contains Element    ${txtNoDBInstance}    timeout=15s


@ikanias The existing keywords should not be removed for the success of other test cases. I hope this section has been included to mitigate No database instance error message, which can be handled with conditional block.

mrrajan · 2023-03-13T06:11:16Z

resources/keywords/provision_dbinstance.resource


 *** Keywords ***
 User Navigates To Create Database Instance Screen From Database Access Page
    User Navigates To Database Access Under Data Services
    Wait Until Page Contains Element    ${titleDatabaseAccess}
-    Select Create Database Instance From Configure Button DropDown
+    Select Create Database Instance From Configuration Button DropDown Provision


@ikanias This is been discussed on earlier comment

The name of the value in the drop down list was changed, so I changed the name of the function. The reason is to verify that if there are other tests or keywords that are using the old keyword.

Can you please review as I recall version 0.5.0 uses "Configure" option and "Configuration" used in earlier versions.

mrrajan · 2023-03-13T06:11:22Z

resources/keywords/provision_dbinstance.resource

-    Select Create Database Instance From Configure Button DropDown
+    Select Create Database Instance From Configuration Button DropDown Provision
+
+Select ${option} From ${menu} Button DropDown Provision


The same as the previous comment

Please review with earlier comments

mrrajan · 2023-03-13T06:13:57Z

resources/keywords/provision_dbinstance.resource

@@ -36,10 +44,20 @@ Toggle Database Provider Drop Down ${isv_name}
    ...    Toggle RDS Database ${engine} Drop Down

 Toggle RDS Database ${engine} Drop Down
-    Select From List By Label    ${engineTypeDrpDwn}    Select one
-    Select From List By Label    ${engineTypeDrpDwn}    ${engine}
+    #Select From List By Label    ${engineTypeDrpDwn}    Select one


@ikanias Please remove the commented keywords and keep the comments. Do we need 15s x 2s wait time for the value on list to be selected?

I see what you are saying. I just wanted to leave the commented keywords so we would know how to change back when the bug will be fixed. This is temporary.
If this is still an issue I will remove it.

@ikanias Can you please review as the bug marked as done and unresolved. And Please review the wait time.

OK will check.

mrrajan · 2023-03-13T06:14:12Z

resources/keywords/provision_dbinstance.resource

    Element Should Be Visible    ${engineTypeDrpDwnOptn}

+Toggle RDS Instance Class Drop Down
+    #Select From List By Label    ${instClassDrpDwn}    Select one


@ikanias Please remove the commented keyword

Again, this is because of the same reason as my previous comment. If this is still an issue I will remove it.

Please review

mrrajan · 2023-03-13T06:15:05Z

resources/object_repo/import_dbaasinventory_obj.resource

@@ -27,8 +27,9 @@ ${btnCreateEnabled}             //button[contains(.,"Create") and @aria-disabled
 ${lblDBInstSuccess}             //h2[contains(.,"Database instances") and contains(.,"successful")]
 ${btnViewProviderAcc}           //button[contains(.,"View Provider Accounts")]
 ${tblInstanceTable}             id:instance-table
-${btnMenuDropDown}              //button[contains(.,"<<menu>>")]
-${btnMenuOptDropDown}           //a[contains(.,"<<menuopt>>")]
+${btnMenuDropDown}              //*[@id="toggle-id-4"]


These might removed based on the above comments

Look at my previous comments. The "menu" we look for does not exist anymore in the DOM and it fails all the tests.

Please review based on the earlier comments

mrrajan · 2023-03-13T06:17:49Z

resources/object_repo/installed_operators_obj.resource

@@ -6,7 +6,7 @@ Object Repository for Installed Operators Screen
 ${elemDbaasStatus}          //a[contains(.,"OpenShift Database Access Operator")]//ancestor::tr/td[contains(.,"Succeeded")]
 ${titleDbaasOperator}       //h1[contains(.,"OpenShift Database Access Operator") and contains(@class,"logo__name")]
 ${elemDbaasInvStatus}       //td[contains(.,"<<paname>>")]/parent::tr/td[contains(.,"SpecSynced, InventoryReady")]
-${titleDbaasInventories}    //h1[contains(.,"DBaaSInventories")]
+${titleDbaasInventories}    //h1[contains(.,"DBaaSInventorys")]


@ikanias Do we still have this error? I hope this is been handled with keyword "User Is On DBaaSInventory Screen" on navigation.resource file

I saw that it was fixed and should be working on 4.13 but they did not mention which version of 4.13.
In the time when I ran the tests it was still displayed with a 'Y'.

Hmm, We do have the object recorded on the same file on line 18. And on keyword -

rhoda-ci/resources/keywords/navigation.resource

Line 77 in 34095f2

User Is On DBaaSInventory Screen

this issue being handled. Please let me know if the test case failed without these changes.

OK will check

mrrajan

Requesting changes

mrrajan · 2023-03-29T10:44:47Z

resources/keywords/import_provider_account.resource

@@ -284,6 +288,14 @@ User Imports ${isv} Provider Account Using CLI
 Provider Account Imported Successfully Using CLI
    Wait Until Keyword Succeeds    4x    5s    Describe Provider Account Using OC CLI

+#User Navigates To Add ${databaseProvider} Topology Screen From Developer View


Please remove the commented sections

mrrajan · 2023-03-29T10:59:22Z

resources/object_repo/import_dbaasinventory_obj.resource

@@ -27,8 +27,9 @@ ${btnCreateEnabled}             //button[contains(.,"Create") and @aria-disabled
 ${lblDBInstSuccess}             //h2[contains(.,"Database instances") and contains(.,"successful")]
 ${btnViewProviderAcc}           //button[contains(.,"View Provider Accounts")]
 ${tblInstanceTable}             id:instance-table
-${btnMenuDropDown}              //button[contains(.,"<<menu>>")]
-${btnMenuOptDropDown}           //a[contains(.,"<<menuopt>>")]
+${btnMenuDropDown}              //*[@id="toggle-id-4"]


Please review based on the earlier comments

mrrajan · 2023-03-29T11:02:18Z

resources/object_repo/installed_operators_obj.resource

@@ -6,7 +6,7 @@ Object Repository for Installed Operators Screen
 ${elemDbaasStatus}          //a[contains(.,"OpenShift Database Access Operator")]//ancestor::tr/td[contains(.,"Succeeded")]
 ${titleDbaasOperator}       //h1[contains(.,"OpenShift Database Access Operator") and contains(@class,"logo__name")]
 ${elemDbaasInvStatus}       //td[contains(.,"<<paname>>")]/parent::tr/td[contains(.,"SpecSynced, InventoryReady")]
-${titleDbaasInventories}    //h1[contains(.,"DBaaSInventories")]
+${titleDbaasInventories}    //h1[contains(.,"DBaaSInventorys")]


Hmm, We do have the object recorded on the same file on line 18. And on keyword -

rhoda-ci/resources/keywords/navigation.resource

Line 77 in 34095f2

User Is On DBaaSInventory Screen

this issue being handled. Please let me know if the test case failed without these changes.

mergify · 2023-05-08T09:59:15Z

This pull request now has conflicts with the target branch. Please resolve conflicts.

ikanias force-pushed the rds_ui_changes branch from 8f38884 to 0d2479a Compare March 12, 2023 18:13

mrrajan reviewed Mar 13, 2023

View reviewed changes

mrrajan requested changes Mar 13, 2023

View reviewed changes

ikanias force-pushed the rds_ui_changes branch from 0d2479a to 34095f2 Compare March 29, 2023 10:11

mrrajan reviewed Mar 29, 2023

View reviewed changes

mrrajan requested changes Mar 29, 2023

View reviewed changes

Fixing RDS UI changes and the application to instance binding

2cd02e7

ikanias force-pushed the rds_ui_changes branch from 34095f2 to 2cd02e7 Compare April 5, 2023 14:09

Fixing RDS UI changes and the application to instance binding #83

Are you sure you want to change the base?

Fixing RDS UI changes and the application to instance binding #83

Conversation

ikanias commented Mar 12, 2023

Choose a reason for hiding this comment

ikanias Mar 23, 2023 • edited Loading

Choose a reason for hiding this comment

mrrajan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ikanias Mar 23, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ikanias Mar 23, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ikanias Mar 23, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ikanias Mar 23, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ikanias Mar 23, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mrrajan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mergify bot commented May 8, 2023

ikanias Mar 23, 2023 •

edited

Loading

ikanias Mar 23, 2023 •

edited

Loading

ikanias Mar 23, 2023 •

edited

Loading

ikanias Mar 23, 2023 •

edited

Loading

ikanias Mar 23, 2023 •

edited

Loading

ikanias Mar 23, 2023 •

edited

Loading