Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHCOS partition resizing #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jeniferh
Copy link

Updating the custom paritioning config:

  1. Configure 600G for RHCOS sysroot
  2. Create 100G partition, intended to be used as LSO storageclass for Monitoring
  3. Create partition using the rest of the device, intended to be used as an OSD

@RamLavi
Copy link
Collaborator

RamLavi commented Nov 18, 2021

Hey @jeniferh, there is currently a problem with the ci. The issue is currently handled by this PR.
does ci tests pass locally for you?

You can also try to rebase your PR with thePR fix coreos/coreos-assembler#2576 to be able to get CI to pass

@RamLavi
Copy link
Collaborator

RamLavi commented Nov 24, 2021

Hey @jeniferh, please rebase your PR on top of latest main branch so that the ci will pass

Updating the custom paritioning config:
1. Configure 600G for RHCOS sysroot
2. Create 100G partition, intended to be used as LSO storageclass for Monitoring
3. Create partition using the rest of the device, intended to be used as an OSD
@jeniferh
Copy link
Author

Thanks @RamLavi I just rebased, sorry for the delay I was OOO.

**TIP:** To change the RHCOS sysroot partition size (currently set to 600G) you can use the following before creating the ign file:

```
sed -i -e "s/OFFSET=600G/OFFSET=120G/" custom-config.fcc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RamLavi should we add this to the make file?

Copy link
Collaborator

@RamLavi RamLavi Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kobi86 good question, but remember the Makefile is in a different branch..

@jeniferh do we just want to notify on the README that we can change the OFFSET or do we want to really change it?
if the answer is the latter then I wonder why aren't we just changing this on the custom-config.fcc?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally giving RHCOS 600GB is good practice since by default all container image storage (and Monitoring etc. if not configured otherwise) will use this space, I just wanted to note how that value could be changed in very space-constrained environments if needed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, so to answer @kobi86 I think that on simplify-networking branch this should be added to the README as a note and not to the makefile..

Copy link
Collaborator

@RamLavi RamLavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@RamLavi
Copy link
Collaborator

RamLavi commented Nov 20, 2022

jeniferh this PR was lgtmed a long time ago but did not get approve
is this still something you want to be merged to the main branch?

@jeniferh
Copy link
Author

Hey @RamLavi, these changes are used by our customer for awhile now, although one issue is it assumes a 1.5TB+ disk size. There may be a better solution (i.e. partitioning via ignition instead of sgdisk) but it has been working for them as-is.

@RamLavi
Copy link
Collaborator

RamLavi commented Dec 19, 2022

The importance of this repo is that is is as much aligned to the customer's actual setup.

Please change the commit message to have a signature and I'll merge it :)

git commit -s --amend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants