-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHCOS partition resizing #49
base: main
Are you sure you want to change the base?
Conversation
Hey @jeniferh, there is currently a problem with the ci. The issue is currently handled by this PR. You can also try to rebase your PR with thePR fix coreos/coreos-assembler#2576 to be able to get CI to pass |
Hey @jeniferh, please rebase your PR on top of latest main branch so that the ci will pass |
Updating the custom paritioning config: 1. Configure 600G for RHCOS sysroot 2. Create 100G partition, intended to be used as LSO storageclass for Monitoring 3. Create partition using the rest of the device, intended to be used as an OSD
Thanks @RamLavi I just rebased, sorry for the delay I was OOO. |
**TIP:** To change the RHCOS sysroot partition size (currently set to 600G) you can use the following before creating the ign file: | ||
|
||
``` | ||
sed -i -e "s/OFFSET=600G/OFFSET=120G/" custom-config.fcc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RamLavi should we add this to the make file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally giving RHCOS 600GB is good practice since by default all container image storage (and Monitoring etc. if not configured otherwise) will use this space, I just wanted to note how that value could be changed in very space-constrained environments if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, so to answer @kobi86 I think that on simplify-networking
branch this should be added to the README as a note and not to the makefile..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
jeniferh this PR was lgtmed a long time ago but did not get approve |
Hey @RamLavi, these changes are used by our customer for awhile now, although one issue is it assumes a 1.5TB+ disk size. There may be a better solution (i.e. partitioning via ignition instead of sgdisk) but it has been working for them as-is. |
The importance of this repo is that is is as much aligned to the customer's actual setup. Please change the commit message to have a signature and I'll merge it :)
|
Updating the custom paritioning config: