-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(old) Move from 2d to 3d array operations #11
Conversation
@@ -230,6 +236,8 @@ def run_pipeline(self, **pipeline_kws): | |||
|
|||
self.pipeline_kws.update(pipeline_kws) | |||
|
|||
# raw_wavefront = revert_to_data_input_format( | |||
# self.fft.data_format, raw_wavefront) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be removed
Hey @paulmueller, I know you are picky with the commit history. This PR is just branched off from #8, and therefore has old commits where I worked with the Cupy code. So the history isn't perfectly "clean". I've cleaned this up, but if you really want me to create a fresh branch from main, let me know. |
Yes, please create a fresh branch. It should be fairly simple though (create new branch and copy paste all files with override to the new working directory). |
This is being continued in #12 |
About
We should allow stacks of 2D arrays as inputs. This will likely speed up processing of large datasets, and certainly will when we add Cupy as an FFTFilter (#10). Several things to note:
To do
run_pipeline
steps for OAH and QLSI should also work with 3D arrays.