Transaction section #121
Merged
Transaction section #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've implemented and fixed the 'Transactions' page, particularly the 'Categories' and 'Accounts' tabs. Categories: - Adjusted the color scheme for both the list and the graph (fixed in RIP-Comm#103 '[Categories Tab] Graph should take colors by category'). - Fixed the list (space between items and borderRadius). Accounts: - Implemented the page according to the Figma design. - Enabled backend graph functionality with accounts. - Enabled backend list functionality with accounts and transactions. TODO: - (As in the categories tab) 'Income' and 'Expenses' filters do not change the view."
mikev-cw
approved these changes
Nov 29, 2023
|
Very well done! I'm merging this, thank you!!! PS: Failing checks are known issues, we'll fix that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented and fixed the 'Transactions' page, particularly the 'Categories' and 'Accounts' tabs.
Categories:
- Adjusted the color scheme for both the list and the graph (fixed in #103 '[Categories Tab] Graph should take colors by category').
- Fixed the list (space between items and borderRadius).
Accounts:
- Implemented the page according to the Figma design.
- Enabled backend graph functionality with accounts.
- Enabled backend list functionality with accounts and transactions.
TODO:
- (As in the categories tab) 'Income' and 'Expenses' filters do not change the view."
demo.mp4