Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add beta light/dark mode 1.1 #122

Merged
merged 9 commits into from
Nov 29, 2023

Conversation

giovanni-ercolano
Copy link
Contributor

I made some changes from the previous pull request, in particular I corrected what I had been told previously, I hope everything is correct now. I specify that obviously not all pages have an exact implementation of dark mode but it is due to the fact that they are still under development of course.

Ps. I tried to insert only the lib folder as you requested, but it was done only with the last commit, from next time I will start from the beginning.

@mikev-cw
Copy link
Collaborator

mikev-cw commented Nov 29, 2023

Hello, and thank you for your contribution!
I've pushed a commit to revert most system files. Please be aware of this in the future.
Also please use only english coding for comments too.
If you want, we would really appreciate if you could monitor all dark mode stuff while developing goes forward, and fix possible problems.

Thank you, bye!!

@mikev-cw mikev-cw merged commit 1edd352 into RIP-Comm:main Nov 29, 2023
1 check passed
@giovanni-ercolano
Copy link
Contributor Author

Hi, I'm very happy that my work went well since this was my first open source contribution. That said, I will definitely continue working on the project in the future.
Thanks again everyone, bye.

@giovanni-ercolano giovanni-ercolano deleted the test-dark-mode branch November 29, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants