Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced theme handling #124

Closed
wants to merge 1 commit into from

Conversation

andreadelsarto
Copy link

Added support for dark mode, auto theme based on system settings, and persistent theme state across app restarts. Also fixed alignment issue with a button.

…d on system settings, and persistent theme state across app restarts. Also fixed alignment issue with a button.
@theperu
Copy link
Collaborator

theperu commented Dec 5, 2023

Good work! I just have three questions before moving forward and merging this PR:

  1. We merged another PR in the meantime which means that you should do a rebase.
  2. Did you check the Transactions page? Because it looks like we have more than one issue there with the dark theme
  3. Did you make the change for the dynamic icon on Android? Do you need new graphics to do it?

Apart from this everything looks good to me and from what I saw on Discord @mikev-cw is on the same page

@andreadelsarto
Copy link
Author

Good work! I just have three questions before moving forward and merging this PR:

  1. We merged another PR in the meantime which means that you should do a rebase.
  2. Did you check the Transactions page? Because it looks like we have more than one issue there with the dark theme
  3. Did you make the change for the dynamic icon on Android? Do you need new graphics to do it?

Apart from this everything looks good to me and from what I saw on Discord @mikev-cw is on the same page

Thanks!! I need to check for the Transaction page before do the fix of pubspec.lock.
For the dynamic icon I remake the logo on svg :) so i'll try to make the dynamic icon.

I'll fix it soon

@theperu
Copy link
Collaborator

theperu commented Jan 31, 2024

Hi! Just checking in, how is it going? Let me know if you have any issue or problem working on this PR :)

@andreadelsarto
Copy link
Author

andreadelsarto commented Feb 28, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants