Do not encode max length in ROA when it is redundant #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjpbakker
reviewed
Feb 23, 2024
src/main/java/net/ripe/rpki/commons/crypto/cms/roa/RoaCmsBuilder.java
Outdated
Show resolved
Hide resolved
ties
force-pushed
the
feature/no-redundant-maxlength-in-roa
branch
from
b7b296b to
aae17e6
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ties
force-pushed
the
feature/no-redundant-maxlength-in-roa
branch
from
aae17e6 to
dda0c63
Compare
lolepezy
reviewed
Feb 23, 2024
| import static org.junit.jupiter.api.Assertions.fail; | ||
|
|
||
|
|
||
| public class RoaPrefixTest { | ||
| @Test | ||
| public void shouldEqualWhenSemanticallyEqual() { |
There was a problem hiding this comment.
Should we have property tests instead of this?
Making sure that equals/hashCode/compare are all coherent with each other is necessary
and there should be a lot of tests, so it makes sense to use property testing here.
There was a problem hiding this comment.
The logic is quite simple so I do not see the need for many cases. I would want many edge conditions though.
You could model the edge conditions in property based testing and then randomise inputs. But for just testing these contracts I think that these cases show very explicitly that you cover the core.
bjpbakker
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not encode the max length in a ROA when it is present but redundant.