Merge branch 'develop' into 3485-reduce-compile-time-for-migraphx

ROCm · Jan 29, 2025 · f285b78 · f285b78
2 parents 90d61d0 + 879f306
commit f285b78
Show file tree

Hide file tree

Showing 64 changed files with 986 additions and 502 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -117,3 +117,7 @@ CheckOptions:
     value:           MIGRAPHX_
   - key:             readability-identifier-naming.ConstexprMethodIgnoredRegexp
     value:           'quiet_NaN|signaling_NaN'
+  - key:             readability-operators-representation.BinaryOperators
+    value:           'and;or;not'
+  - key:             readability-operators-representation.OverloadedOperators
+    value:           'and;or;not'
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -20,7 +20,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Cancel Previous Runs
-        uses: styfle/cancel-workflow-action@0.11.0
+        uses: styfle/cancel-workflow-action@0.12.1
         with:
           access_token: ${{ github.token }}
 
@@ -35,7 +35,7 @@ jobs:
 
     steps: 
       - name: Checkout Code
-        uses: actions/checkout@v4.1.1
+        uses: actions/checkout@v4.2.2
 
       - name: Create Image Tag
         id: image_hash
@@ -72,7 +72,7 @@ jobs:
     needs: check_image
     if: ${{ needs.check_image.outputs.imageexists != 'true' }}
     steps:
-    - uses: actions/checkout@v4.1.1
+    - uses: actions/checkout@v4.2.2
 
     - name: Build and publish 
       env:            
@@ -94,7 +94,7 @@ jobs:
     needs: check_image
     if: ${{ needs.check_image.outputs.imageexists_sles != 'true' }}
     steps:
-    - uses: actions/checkout@v4.1.1
+    - uses: actions/checkout@v4.2.2
     - name: Build and publish SLES
       env:            
         DOCKER_TAG_SLES: ${{ needs.check_image.outputs.imagetag_sles }}
@@ -118,10 +118,10 @@ jobs:
 
     if: ${{ !cancelled() && (needs.build_image.result == 'success' || needs.build_image.result == 'skipped') }}
     steps: 
-    - uses: actions/checkout@v4.1.1
+    - uses: actions/checkout@v4.2.2
 
     - name: Restore cache files for tidy
-      uses: actions/cache/restore@v3 
+      uses: actions/cache/restore@v4.2.0
       id: tidy_restore
       with:
         path: tidy-cache
@@ -157,7 +157,7 @@ jobs:
         gh actions-cache delete ${{ steps.tidy_restore.outputs.cache-matched-key }} --confirm
 
     - name: Save cache files for tidy
-      uses: actions/cache/save@v3 
+      uses: actions/cache/save@v4.2.0
       if: always()
       with:
         path: tidy-cache
@@ -172,11 +172,11 @@ jobs:
 
     if: ${{ !cancelled() && (needs.build_image.result == 'success' || needs.build_image.result == 'skipped') }}
     steps:
-    - uses: actions/checkout@v4.1.1
+    - uses: actions/checkout@v4.2.2
 
     - name: Restore cache files for cppcheck
       id: cppcheck_restore
-      uses: actions/cache/restore@v3
+      uses: actions/cache/restore@v4.2.0
       with:
         path: cppcheck-cache
         key: cppcheck-cache-1-${{ hashFiles('tools/cppcheck/rules.xml', 'tools/cppcheck/migraphx.py', 'CMakeLists.txt') }}-${{ github.ref }}
@@ -207,7 +207,7 @@ jobs:
         gh actions-cache delete ${{ steps.cppcheck_restore.outputs.cache-matched-key }} --confirm
 
     - name: Save cache files for cppcheck
-      uses: actions/cache/save@v3
+      uses: actions/cache/save@v4.2.0
       if: always()
       with:
         path: cppcheck-cache
@@ -222,7 +222,7 @@ jobs:
 
     if: ${{ !cancelled() && (needs.build_image.result == 'success' || needs.build_image.result == 'skipped') }}
     steps:
-    - uses: actions/checkout@v4.1.1
+    - uses: actions/checkout@v4.2.2
       with:
         fetch-depth: 0
 
@@ -253,12 +253,12 @@ jobs:
 
     if: ${{ !cancelled() && (needs.build_SLES_image.result == 'success' || needs.build_SLES_image.result == 'skipped') }}      
     steps:
-    - uses: actions/checkout@v4.1.1
+    - uses: actions/checkout@v4.2.2
       with:
         fetch-depth: 0
 
     - name: Restore cache files for ccache
-      uses: actions/cache/restore@v3 
+      uses: actions/cache/restore@v4.2.0
       id: ccache_restore
       with:
         path: ${{ github.workspace }}/ccache
@@ -297,7 +297,7 @@ jobs:
         gh actions-cache delete ${{ steps.ccache_restore.outputs.cache-matched-key }} --confirm
 
     - name: Save cache files for ccache
-      uses: actions/cache/save@v3 
+      uses: actions/cache/save@v4.2.0
       if: always()
       with:
         path: ${{ github.workspace }}/ccache
@@ -319,7 +319,7 @@ jobs:
         swap-storage: true
         docker-images: true
 
-    - uses: actions/checkout@v4.1.1
+    - uses: actions/checkout@v4.2.2
     - name: Set up Python
       uses: actions/setup-python@v4
       with:
@@ -350,7 +350,7 @@ jobs:
         swap-storage: true
         docker-images: true
 
-    - uses: actions/checkout@v4.1.1
+    - uses: actions/checkout@v4.2.2
       with:
         fetch-depth: 0 # Fetch the entire repository history and all branches
     - name: Set up Python
@@ -399,15 +399,15 @@ jobs:
         python -m pip install --upgrade pip
         pip install https://github.com/RadeonOpenCompute/rbuild/archive/master.tar.gz
 
-    - uses: actions/checkout@v4.1.1
+    - uses: actions/checkout@v4.2.2
     - name: Set up Python
       uses: actions/setup-python@v4
       with:
         python-version: 3.7
     - name: Cache dependencies
       # Ignore the failure of a step and avoid terminating the job.
       continue-on-error: true
-      uses: actions/cache@v3
+      uses: actions/cache@v4.2.0
       id: deps_cache
       with:
         # This path is specific to Ubuntu
@@ -420,7 +420,7 @@ jobs:
       run: rbuild prepare -d cget -s gh
 
     - name: Restore cache files for ccache
-      uses: actions/cache/restore@v3 
+      uses: actions/cache/restore@v4.2.0
       id: ccache_restore
       with:
         path: ${{ github.workspace }}/ccache
@@ -458,7 +458,7 @@ jobs:
         gh actions-cache delete ${{ steps.ccache_restore.outputs.cache-matched-key }} --confirm
 
     - name: Save cache files for ccache
-      uses: actions/cache/save@v3 
+      uses: actions/cache/save@v4.2.0
       if: always()
       with:
         path: ${{ github.workspace }}/ccache
@@ -512,7 +512,7 @@ jobs:
         swap-storage: true
         docker-images: true
 
-    - uses: actions/checkout@v4.1.1
+    - uses: actions/checkout@v4.2.2
     - name: Set up Python
       uses: actions/setup-python@v4
       with:
@@ -521,7 +521,7 @@ jobs:
     - name: Cache dependencies
       # Ignore the failure of a step and avoid terminating the job.
       continue-on-error: true
-      uses: actions/cache@v3
+      uses: actions/cache@v4.2.0
       with:
         # This path is specific to Ubuntu
         path: ${{ github.workspace }}/cget
@@ -539,7 +539,7 @@ jobs:
 
     - name: Restore cache files for ccache
       id: ccache_restore_fpga
-      uses: actions/cache/restore@v3 
+      uses: actions/cache/restore@v4.2.0
       with:
         path: ${{ github.workspace }}/ccache
         key: ${{ matrix.os }}-${{ matrix.configuration }}-ccache-${{ github.ref }}
@@ -577,7 +577,7 @@ jobs:
         gh actions-cache delete ${{ steps.ccache_restore_fpga.outputs.cache-matched-key }} --confirm
 
     - name: Save cache files for ccache
-      uses: actions/cache/save@v3 
+      uses: actions/cache/save@v4.2.0
       if: always()
       with:
         path: ${{ github.workspace }}/ccache

diff --git a/.github/workflows/clean-closed-pr-caches.yaml b/.github/workflows/clean-closed-pr-caches.yaml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out code
-        uses: actions/checkout@v4.1.1
+        uses: actions/checkout@v4.2.2
 
       - name: Cleanup
         run: |

diff --git a/.github/workflows/performance.yaml b/.github/workflows/performance.yaml
@@ -60,7 +60,7 @@ jobs:
       perf_timeout: ${{ steps.read_config.outputs.perf_timeout }}
     steps:
       - name: checkout
-        uses: actions/checkout@v4.1.1
+        uses: actions/checkout@v4.2.2
       - name: read_config
         id: read_config
         run: |

diff --git a/.github/workflows/rocm-image-release.yaml b/.github/workflows/rocm-image-release.yaml
@@ -35,9 +35,9 @@ jobs:
   release:
     uses: ROCm/migraphx-benchmark/.github/workflows/rocm-release.yml@main
     with:
-      rocm_release: ${{ github.event.inputs.rocm_release || '5.1' }}
+      rocm_release: ${{ github.event.inputs.rocm_release || '6.3.1' }}
       benchmark-utils_repo: ${{ github.event.inputs.benchmark-utils_repo || 'ROCm/migraphx-benchmark-utils' }}
-      base_image: ${{ github.event.inputs.base_image || 'rocm/dev-ubuntu-20.04' }}
+      base_image: ${{ github.event.inputs.base_image || 'rocm/dev-ubuntu-22.04' }}
       docker_image: ${{ github.event.inputs.docker_image || 'rocm-migraphx' }}
       branch_name: ${{ github.event.inputs.branch_name || 'develop' }}
       build_navi: ${{ github.event.inputs.build_navi || '0' }}

diff --git a/.github/workflows/sync-onnxrt-main.yaml b/.github/workflows/sync-onnxrt-main.yaml
@@ -18,7 +18,7 @@ jobs:
       - name: echo_sha1
         run: echo ${{ env.onnxsha }}
 
-      - uses: actions/checkout@v4.1.1
+      - uses: actions/checkout@v4.2.2
         with: 
           ref: develop
 
@@ -54,4 +54,4 @@ jobs:
             TedThemistokleous
             causten
           draft: false
-          base: develop
+          base: develop
diff --git a/.github/workflows/sync_rocMLIR.yaml b/.github/workflows/sync_rocMLIR.yaml
@@ -12,12 +12,12 @@ on:
         type: string
         description: ROCm release version
         required: true
-        default: '6.0.2'
+        default: '6.3.1'
       base_image:
         type: string
         description: Base image for ROCm Docker build
         required: true
-        default: 'rocm/dev-ubuntu-20.04'
+        default: 'rocm/dev-ubuntu-22.04'
       docker_image:
         type: string
         description: Docker image name for rocm Docker build
@@ -56,7 +56,7 @@ jobs:
       repo_org: ${{ steps.read_config.outputs.repo_org }}
     steps:
       - name: checkout
-        uses: actions/checkout@v4.1.1
+        uses: actions/checkout@v4.2.2
       - name: read_config
         id: read_config
         run: |

diff --git a/.github/workflows/unreleased_rocm.yaml b/.github/workflows/unreleased_rocm.yaml
@@ -13,7 +13,7 @@ on:
       rocm_release:
         description: Use tuned MIOpen database for ROCm release
         required: true
-        default: '6.0.2'
+        default: '6.3.1'
       performance_reports_repo:
         description: Repository where performance reports are stored
         required: true
@@ -56,7 +56,7 @@ jobs:
       perf_timeout: ${{ steps.read_config.outputs.perf_timeout }}
     steps:
       - name: checkout
-        uses: actions/checkout@v4.1.1
+        uses: actions/checkout@v4.2.2
       - name: read_config
         id: read_config
         run: |

diff --git a/.github/workflows/weekly_master_sync.yaml b/.github/workflows/weekly_master_sync.yaml
@@ -11,7 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
 
-      - uses: actions/checkout@v4.1.1
+      - uses: actions/checkout@v4.2.2
         with: 
           ref: develop
           fetch-depth: '0'

diff --git a/docs/dev/env_vars.rst b/docs/dev/env_vars.rst
@@ -154,6 +154,7 @@ Disables layrnorm fusion.
 Set to "1", "enable", "enabled", "yes", or "true" to use.
 Disables use of MIOpen for pooling operations and uses JIT implementation instead.
 
+
 Compilation traces
 ----------------------
 
@@ -177,6 +178,11 @@ Prints the compile pass and the program after the pass.
 Set to "1", "enable", "enabled", "yes", or "true" to use.
 Times the compile passes.
 
+.. envvar:: MIGRAPHX_DISABLE_PASSES
+
+Set to the name of the pass you want to skip.  Comma separated list is supported
+Example "rewrite_pooling,rewrite_gelu"
+
 
 GPU kernels JIT compilation debugging 
 ----------------------------------------

diff --git a/docs/sphinx/requirements.in b/docs/sphinx/requirements.in
@@ -1,2 +1,2 @@
-rocm-docs-core==1.12.0
+rocm-docs-core==1.14.1
 sphinx-collapse