Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link CMAKE_DL_LIBS. #99

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

stellaraccident
Copy link
Contributor

Was failing to link on AlmaLinux8.

dayatsin-amd and others added 5 commits November 20, 2023 15:52
Add new structures for HW Exception events and copy data from KFD to
expose to upper layers.

Change-Id: Icd5eb98997c47620e3b86277ab6d3abb7ed7d56f
granularity check is added in kfd w/ below patch:

commit 270c7a8375a91fec2fb4e2c253e3955d9b7540b4
Author: Jesse Zhang <[email protected]>
Date:   Fri Oct 20 09:43:51 2023 +0800

    drm/amdkfd: Fix shift out-of-bounds issue

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
index a690dced6860..f2b33fb2afcf 100644

Change-Id: I8cb037e3bf5db0a85661494b77e59984eca4d98d

--- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
@@ -781,7 +781,7 @@ svm_range_apply_attrs(struct kfd_process *p, struct svm_range *prange,
                        prange->flags &= ~attrs[i].value;
                        break;
                case KFD_IOCTL_SVM_ATTR_GRANULARITY:
-                       prange->granularity = attrs[i].value;
+                       prange->granularity = min_t(uint32_t, attrs[i].value, 0x3F);
                        break;
                default:
                        WARN_ONCE(1, "svm_range_check_attrs wasn't called?");

Test cases have to been modified accordingly otherwise KFDSVMRangeTest.SetGetAttributesTest
fails.

Signed-off-by: Yifan Zhang <[email protected]>
Change-Id: Ifff47556bc398da6b18ad26ac545d139b63b0c92
(cherry picked from commit d36c28c)
Due to a kernel bug where large unified memory ends up with an
incorrect fragment size during migration, the debugger ends up
triggering save area corruption.

Since the debugger does not work in virtualization and the performance
requirement to allocate the save area as unified memory is only for
GFX1101 virtualized devices, allocate the save area in system memory
for all other GFX11 devices.

Note that devices prior to GFX11 have not exhibited issues so keep
the save area in unified memory for these devices.

Signed-off-by: Jonathan Kim <[email protected]>
Change-Id: I9c09a9af232a26aaece1c1663fdfad756fbbcdf8
This test is still causing issue on GFX11.

Change-Id: I4c12e2a410598a7f820bee96eccac6fae9642208
Signed-off-by: David Belanger <[email protected]>
Was failing to link on AlmaLinux8.
@kentrussell
Copy link
Contributor

Thanks for your contribution! I have pulled this internally and it'll be in our next release. I'll close this off at that time.

@kentrussell
Copy link
Contributor

So this one missed 6.1, but it should be in the 6.2 release.

@kentrussell kentrussell force-pushed the master branch 2 times, most recently from 56a16c2 to 06a9b94 Compare December 6, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants