Hide all warnings when compiling the mscclpp project #1501
+39
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…piling mscclpp project. Switched this behaviour on the MSCCLPP_HIDE_WARNINGS flag in rccl cmake.
corey-derochie-amd
requested review from
wenkaidu,
gilbertlee-amd,
akolliasAMD,
edgargabriel,
PedramAlizadeh,
nusislam,
nileshnegi,
KawtharShafie,
AtlantaPepsi,
mberenjk,
mustafabar,
thananon,
JhaShweta1 and
haripriya-amd
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Do not mention proprietary info or link to internal work items in this PR.
What were the changes?
Added a patch and cmake flags to hide all warnings generated when compiling mscclpp project. Switched this behaviour on the MSCCLPP_HIDE_WARNINGS flag in rccl cmake.
Why were the changes made?
The build of mscclpp generated many warnings that added noise to the rccl build process. Since we do not maintain mscclpp, it may not be important to see these warnings.
How was the outcome achieved?
Passed
CMAKE_CXX_FLAGS=-Wno-everythingto mscclpp cmake process. Used another patch to disable lines in mscclpp CMakeLists.txt that enabled or created warnings.Approval Checklist
Do not approve until these items are satisfied.