CMake: use -m64 only on x86-64 hosts
#63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`-m64` only applies to x86-64, it's more reasonable to enable it only on `x86_64` host. It fixes build on some other platforms as well.
aimixsaka
added a commit
to aimixsaka/archriscv-packages
that referenced
this pull request
Nov 19, 2023
- Applied patch ROCm/rocminfo#63 (Remove '-m64' c++ flag on architectures that don't support/need it.)
felixonmars
pushed a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Nov 19, 2023
- Applied patch ROCm/rocminfo#63 (Remove '-m64' c++ flag on architectures that don't support/need it.)
dayatsin-amd
added a commit
that referenced
this pull request
Jun 3, 2024
-m64 only applies to x86-64, it's more reasonable to enable it only on x86_64 host. It fixes build on some other platforms as well. Provided by user r-value on github https: //github.com//pull/63 Change-Id: I9c1c40d3fa39b0a61d28041fe4998b5e1ad0cdcd
|
Looks like fixed since 6.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-m64only applies to x86-64, it's more reasonable to enable it only onx86_64host.It fixes build on non-amd64 platforms as well.