Indexing of information from the rocminfo application to helping the user to view #95
Conversation
Adding code for new help message
ajitclarencejoseph
requested review from
dayatsin-amd and
shwetagkhatri
as code owners
ajitclarencejoseph
changed the title
ajitclarencejoseph
changed the title
There was a problem hiding this comment.
Sorry for delay in review, overall, it looks good.
I believe agent_number is not used and can be removed.
I will also add @shwetagkhatri as reviewer so she can help applying the change via the internal repository
rocminfo.cc
Outdated
| hsa_status_t err; | ||
| agent_info_t agent_i; | ||
|
|
||
| int *agent_number = reinterpret_cast<int*>(data); |
There was a problem hiding this comment.
It seems agent_number is not used, and it can be removed
There was a problem hiding this comment.
Currently it is not used, I had thought to use it when we need to index the individual agent display. So removed and updated in the fork branch as provided below. Also made some changes in help message display
ajitclarencejoseph@026828a
@shwetagkhatri Also, please review code changes as well. |
As we see that rocminfo provides a list of information and it is very difficult sometimes to look for a particular information in the page. So by indexing the information, it would be useful for the user to get particular information of a device