Add sysFeatures_nvml module #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This almost an entire rewrite of the old likwid_device_create function. The intention is to support PCI addresses and index numbers, but the former ones cannot be supported with the previous API. To avoid a lot of duplicated code, the old likwid_device_create function now shares the important parts of the code with likwid_device_create_from_string.
Most of the features are currently unimplemented, but will follow in future commits.
If these fields are signed, confusing situations occur where a supposedly negative bus ID fails to compare as equal or is formatted incorrectly as string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds sysfeature support for Nvidia NVML. In addition, a few fixes are provided to enable the creation of LikwidDevices of type
nvidia_gpu.