Makefile fixes #648
Merged
Makefile fixes #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipatix
force-pushed
the
makefile-fixes
branch
5 times, most recently
from
9e793d1 to
e16eec1
Compare
To briefly summarize: - It's now possible to run make with --jobs, NOPARALLEL is removed - .ONESHELL is removed, since it causes rules to not cancel if an error occurs. It's speedup is probably negligible anyway. - Add --no-undefined to linker flags. This prevents undefined references going unnoticed during compilation. Previously, an undefined reference would have caused an error only at runtime, which is undesirable., - Remove unecessary dependencies on certain rules. E.g. 'all' in the top-level Makefile depended on BUILD_DIR and PERFMONHEADERS, which is clearly wrong. We don't really care about the headers when writing 'make', what we care about is that PERFMONHEADERS are build when they are needed, which is only the case for C objects. - likwid-bench linker flags are adjusted to use a non-executable stack, which fixes a warning. - BUILD_DIR is removed as target and instead run individually for targets, which write files to BUILD_DIR. - Q works again for debugging (it used to occur twice in the Makefile)
Previously, the sub makefiles would not compile the files they delcared as target. Accordingly, they would always try to rebuild e.g. the .so file, even though it was already up-to-date.
ipatix
force-pushed
the
makefile-fixes
branch
from
f322ed8 to
6c7a243
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit description.
What's still broken: After the .d files are generated for the first time, compilation has to run a second time, even though everything built successfully the first time.
Edit: Should be fixed now.