[bsp][mm32f526x] 1.add mm32f526x bsp; #9940
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.fix when only UART3 is turned on, the compiler does not include this drv_uart.c;
2.add soft i2c;
3.support keil/iar;
2.add at24cxxx package;
supperthomas
requested changes
Jan 21, 2025
|
|
||
| Redistribution and use in source and binary forms, with or without modification, are permitted provided that the | ||
| following conditions are met: | ||
| 1. Redistributions of source code must retain the above copyright notice, |
There was a problem hiding this comment.
厂商库文件请以软件包的方式提交，
参考BSP:
stm32/stm32l496zg-st-nucleo
nrf5x/nrf52840
软件包制作参考
https://www.rt-thread.org/document/site/#/rt-thread-version/rt-thread-standard/development-guide/package/package
|
你好，请帮我审核一下提交packages的PR；谢谢！！！ |
2.Break out of loop if read ADC value exceeds 5ms;
supperthomas
requested changes
Jan 22, 2025
bsp/mm32f526x/drivers/drv_adc.c
Outdated
| @@ -0,0 +1,163 @@ | |||
| /* | |||
| * Copyright (c) 2006-2023, RT-Thread Development Team | |||
|
chasel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
我已经签署CLA了☺ |
supperthomas
approved these changes
Jan 22, 2025
|
commit整合一下吧 |
|
已放假了，年后再弄了(●—●)
…---- 回复的原邮件 ----
| 发件人 | Supper ***@***.***> |
| 日期 | 2025年01月23日 07:33 |
| 收件人 | ***@***.***> |
| 抄送至 | ***@***.***>、State ***@***.***> |
| 主题 | Re: [RT-Thread/rt-thread] [bsp][mm32f526x] 1.add mm32f526x bsp; (PR #9940) |
commit整合一下吧
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
已在MiniBoard-OB 开发板上验证，测试pin设备，adc设备，uart设备；
为什么提交这份PR (why to submit this PR)
贡献新的板级支持，为开源做贡献；
请提供验证的bsp和config (provide the config and bsp)
bsp/mm32f526x->.config
使用gcc编译，已验证gcc编译的固件，理论上可以支持keil和iar的编译方式；
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up