Fail proof coverage directory retrival

Raathigesh · Apr 17, 2019 · 93dfd64 · 93dfd64
1 parent c040497
commit 93dfd64
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/server/services/results.ts b/server/services/results.ts
@@ -207,7 +207,11 @@ export default class Results {
         }
       );
 
-      const filesStr = configProcess.stdout.toString().trim();
+      let filesStr = configProcess.stdout.toString().trim();
+      if (filesStr === "") {
+        filesStr = configProcess.stderr.toString().trim();
+      }
+
       const jestConfig = JSON.parse(filesStr);
       this.coverageDirectory =
         jestConfig.globalConfig && jestConfig.globalConfig.coverageDirectory;

diff --git a/server/static-files.ts b/server/static-files.ts
@@ -25,6 +25,8 @@ export function initializeStaticRoutes(express: exp.Application, root: string) {
   );
 
   pubsub.subscribe("WorspaceInitialized", ({ coverageDirectory }) => {
-    express.use("/coverage", exp.static(coverageDirectory));
+    if (coverageDirectory.trim() !== "") {
+      express.use("/coverage", exp.static(coverageDirectory));
+    }
   });
 }