193 better indication test run status #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync with official fork v1.7.0
When in watch mode, the summary background used to animate all the time. This meant that it was difficult to understand if the test was currently running or if the results you were looking at were the result of the latest test run. With this change the background only animates when a test is actually in progress. If you are in watch mode, the play button turns to a stop button and the background is not animated, But when Jest is running, the background is animating. When jest finishes, the background stops. This addresses issue Raathigesh#193
cherry picking the commit brought in part of another change. this undoes that other change and puts the removed code back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as outlined in #193, this change introduces an isUpdating flag and uses that flag to
control the animated background of the file summary area. This makes it much easier
to determine if the test is currently running or if the results shown can be trusted.