Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding handling for Wolfram API errors #11

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

krachwal
Copy link
Collaborator

@krachwal krachwal commented Dec 19, 2023

Added handling for successful Wolfram API errors (the response has embedded error flagging but returns successful when it fails to come up with a result for any reason).
Added a custom error and API tests (which ran as part of the actions/checks on this PR).

Also added some docstrings and separated coordinate functions from math functions.

@krachwal krachwal self-assigned this Dec 19, 2023
python-backend/wolfram_client.py Outdated Show resolved Hide resolved
python-backend/wolfram_client.py Outdated Show resolved Hide resolved
Copy link

@ketanbj ketanbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me and passing all the checks. I say ship it.

ketanbj
ketanbj previously approved these changes Dec 19, 2023
@krachwal krachwal merged commit 74cc2ce into main Dec 19, 2023
7 checks passed
@krachwal krachwal deleted the kate/wolfram_api_error_handling branch December 19, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants