Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

843: Ensure a fallback for a missing remix origin (mainly for cypress test failures) #481

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danhalson
Copy link
Contributor

Status

What's changed?

Fixes a bad request when no remix_origin is defined, this was leading to cypress integration tests failing.

Steps to perform after deploying to production

N/A

Copy link
Contributor

@loiswells97 loiswells97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES, will be so good to have this fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants