Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Spike adding Scratch project type #1159

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

floehopper
Copy link
Contributor

@floehopper floehopper commented Jan 8, 2025

There's a corresponding branch in editor-standalone that adds a /scratch-project path that can be used to view the Scratch UI. This works because the Cloudflare Pages configuration for the editor-standalone branch is pointing at the deployment of this editor-ui branch in Cloudflare R2.

Note that we set cross-origin-embedder-policy to cross-origin in the dev server config so that we can render the scratch-editor.pages.dev page in our iframe in the web-component.html test page.

Things to do before we can merge

  • Work out how to view Scratch projects vs Python and HTML projects
  • Decide who should be able to see the Scratch editor
  • Configure cross-origin headers to securely allow scratch-editor.pages.dev to be embedded in the iframe
  • Add tests

@floehopper floehopper temporarily deployed to previews/1159/merge January 8, 2025 16:52 — with GitHub Actions Inactive
@floehopper floehopper force-pushed the spike-add-scratch-project-type branch from 42321ff to 847c7aa Compare January 8, 2025 17:00
@floehopper floehopper temporarily deployed to previews/1159/merge January 8, 2025 17:00 — with GitHub Actions Inactive
@floehopper floehopper force-pushed the spike-add-scratch-project-type branch from 847c7aa to cdb854a Compare January 8, 2025 17:06
@floehopper floehopper temporarily deployed to previews/1159/merge January 8, 2025 17:08 — with GitHub Actions Inactive
@floehopper floehopper force-pushed the spike-add-scratch-project-type branch from cdb854a to dcc327a Compare January 8, 2025 17:20
@floehopper floehopper temporarily deployed to previews/1159/merge January 8, 2025 17:20 — with GitHub Actions Inactive
@chrisroos chrisroos temporarily deployed to previews/1159/merge January 9, 2025 14:59 — with GitHub Actions Inactive
@floehopper floehopper force-pushed the spike-add-scratch-project-type branch from a0153b1 to dcc327a Compare January 9, 2025 16:09
@floehopper floehopper temporarily deployed to previews/1159/merge January 9, 2025 16:09 — with GitHub Actions Inactive
@chrisroos chrisroos force-pushed the spike-add-scratch-project-type branch from 869eba9 to fd076a7 Compare January 13, 2025 10:50
@chrisroos chrisroos temporarily deployed to previews/1159/merge January 13, 2025 11:21 — with GitHub Actions Inactive
@chrisroos chrisroos temporarily deployed to previews/1159/merge January 13, 2025 11:24 — with GitHub Actions Inactive
@chrisroos chrisroos temporarily deployed to previews/1159/merge January 13, 2025 11:41 — with GitHub Actions Inactive
@chrisroos chrisroos temporarily deployed to previews/1159/merge January 13, 2025 11:58 — with GitHub Actions Inactive
@chrisroos chrisroos temporarily deployed to previews/1159/merge January 13, 2025 12:02 — with GitHub Actions Inactive
@chrisroos chrisroos temporarily deployed to previews/1159/merge January 13, 2025 12:37 — with GitHub Actions Inactive
@chrisroos chrisroos temporarily deployed to previews/1159/merge January 13, 2025 14:19 — with GitHub Actions Inactive
@floehopper floehopper force-pushed the spike-add-scratch-project-type branch from 2f1a8ab to b422e06 Compare January 13, 2025 16:17
@floehopper floehopper temporarily deployed to previews/1159/merge January 13, 2025 16:17 — with GitHub Actions Inactive
@floehopper floehopper temporarily deployed to previews/1159/merge January 13, 2025 17:01 — with GitHub Actions Inactive
@floehopper floehopper temporarily deployed to previews/1159/merge January 13, 2025 17:20 — with GitHub Actions Inactive
@chrisroos chrisroos temporarily deployed to previews/1159/merge January 14, 2025 17:14 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants