-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Spike adding Scratch project type #1159
Draft
floehopper
wants to merge
1
commit into
main
Choose a base branch
from
spike-add-scratch-project-type
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floehopper
temporarily deployed
to
previews/1159/merge
January 8, 2025 16:52 — with
GitHub Actions
Inactive
floehopper
force-pushed
the
spike-add-scratch-project-type
branch
from
January 8, 2025 17:00
42321ff
to
847c7aa
Compare
floehopper
temporarily deployed
to
previews/1159/merge
January 8, 2025 17:00 — with
GitHub Actions
Inactive
floehopper
force-pushed
the
spike-add-scratch-project-type
branch
from
January 8, 2025 17:06
847c7aa
to
cdb854a
Compare
floehopper
temporarily deployed
to
previews/1159/merge
January 8, 2025 17:08 — with
GitHub Actions
Inactive
floehopper
force-pushed
the
spike-add-scratch-project-type
branch
from
January 8, 2025 17:20
cdb854a
to
dcc327a
Compare
floehopper
temporarily deployed
to
previews/1159/merge
January 8, 2025 17:20 — with
GitHub Actions
Inactive
chrisroos
temporarily deployed
to
previews/1159/merge
January 9, 2025 14:59 — with
GitHub Actions
Inactive
floehopper
force-pushed
the
spike-add-scratch-project-type
branch
from
January 9, 2025 16:09
a0153b1
to
dcc327a
Compare
floehopper
temporarily deployed
to
previews/1159/merge
January 9, 2025 16:09 — with
GitHub Actions
Inactive
chrisroos
had a problem deploying
to
previews/1159/merge
January 13, 2025 10:40 — with
GitHub Actions
Failure
chrisroos
force-pushed
the
spike-add-scratch-project-type
branch
from
January 13, 2025 10:50
869eba9
to
fd076a7
Compare
chrisroos
had a problem deploying
to
previews/1159/merge
January 13, 2025 10:51 — with
GitHub Actions
Failure
chrisroos
had a problem deploying
to
previews/1159/merge
January 13, 2025 10:52 — with
GitHub Actions
Failure
chrisroos
temporarily deployed
to
previews/1159/merge
January 13, 2025 11:21 — with
GitHub Actions
Inactive
chrisroos
temporarily deployed
to
previews/1159/merge
January 13, 2025 11:24 — with
GitHub Actions
Inactive
chrisroos
temporarily deployed
to
previews/1159/merge
January 13, 2025 11:41 — with
GitHub Actions
Inactive
chrisroos
temporarily deployed
to
previews/1159/merge
January 13, 2025 11:58 — with
GitHub Actions
Inactive
chrisroos
temporarily deployed
to
previews/1159/merge
January 13, 2025 12:02 — with
GitHub Actions
Inactive
chrisroos
temporarily deployed
to
previews/1159/merge
January 13, 2025 12:37 — with
GitHub Actions
Inactive
chrisroos
temporarily deployed
to
previews/1159/merge
January 13, 2025 14:19 — with
GitHub Actions
Inactive
floehopper
force-pushed
the
spike-add-scratch-project-type
branch
from
January 13, 2025 16:17
2f1a8ab
to
b422e06
Compare
floehopper
temporarily deployed
to
previews/1159/merge
January 13, 2025 16:17 — with
GitHub Actions
Inactive
floehopper
temporarily deployed
to
previews/1159/merge
January 13, 2025 17:01 — with
GitHub Actions
Inactive
floehopper
temporarily deployed
to
previews/1159/merge
January 13, 2025 17:20 — with
GitHub Actions
Inactive
chrisroos
temporarily deployed
to
previews/1159/merge
January 14, 2025 17:14 — with
GitHub Actions
Inactive
chrisroos
force-pushed
the
spike-add-scratch-project-type
branch
from
January 21, 2025 16:12
210b7ed
to
9df76f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a corresponding branch in editor-standalone that adds a /scratch-project path that can be used to view the Scratch UI. This works because the Cloudflare Pages configuration for the editor-standalone branch is pointing at the deployment of this editor-ui branch in Cloudflare R2.
Note that we set
cross-origin-embedder-policy
tocross-origin
in the dev server config so that we can render the scratch-editor.pages.dev page in our iframe in the web-component.html test page.Things to do before we can merge